fix(deps): remove or type last remaining untyped deps #7211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
commented
Apr 15, 2025
| @@ -56,9 +52,7 @@ async function writeFile(outDir: string, vars: Record<string, string>, file: Ent | |||
| } | |||
|
|
|||
| // High throughput template dir writes | |||
| export async function copyTemplateDir(srcDir: string, outDir: string, vars: any): Promise<string[]> { | |||
| if (!vars) vars = noop | |||
There was a problem hiding this comment.
there's only one caller and it always passes this in
serhalp
force-pushed
the
serhalp/cpla-2572-add-type-declarations-for-all-npm-dependencies
branch
3 times, most recently
from
e84b6c0 to
1049c9a
Compare
ndhoule
approved these changes
Apr 15, 2025
`stripVTControlCharacters` was added in 16.11.0 (we support >+18.14.0)
serhalp
force-pushed
the
serhalp/cpla-2572-add-type-declarations-for-all-npm-dependencies
branch
from
1049c9a to
571215a
Compare
serhalp
deleted the
serhalp/cpla-2572-add-type-declarations-for-all-npm-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
10b297c add type declaration files for untyped
maxstacheandmaxstache-stream563e0b4 add type declaration for untyped
express-loggingThere's also #7050 that removes it entirely, but I don't want to be blocked on this to continue improving type safety.
fe8e4a0 remove untyped
strip-ansi-control-charactersdepstripVTControlCharacterswas added in 16.11.0 (we support >+18.14.0), so we don't need this tiny transform stream wrapper anyway1049c9a fix types and eslint errors in
utils/shell.ts