fix: ensure extension api is always called with the right host #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khendrikse
force-pushed
the
cpla-2629/ensure-cli-uses-proper-host-for-sdk-api
branch
from
2f5374a to
619cd07
Compare
khendrikse
force-pushed
the
cpla-2629/ensure-cli-uses-proper-host-for-sdk-api
branch
from
619cd07 to
574e0bf
Compare
|
This pull request adds or modifies JavaScript ( |
lemusthelroy
approved these changes
Mar 28, 2025
|
This pull request adds or modifies JavaScript ( |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This is a little bit of a messy fix, but I want to unblock @lemusthelroy.
Using the CLI locally to interact with the staging environment did not work because we have some interesting logic going on in netlify the CLI: https://github.com/netlify/cli/blob/b5a5c7525edd28925c5c2e3e5f0f00c4261eaba5/src/lib/build.ts#L136
Essentially the CLI is not passing in the host in the proper way, instead using
testOpts?We should change that logic at some point, but in the meantime, this fix should ensure that we always use the right url for calls to the extension API
Additional header
I'm adding an additional header because I want to keep track of cli vs buildbot calls to the extension API
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)