Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on symfony/http-client (Honestly this time) #153

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jan 31, 2025

Whoops - it appears that HTTP discovery auto installs it 🤦‍♂️

@gsteel gsteel added this to the 1.7.1 milestone Jan 31, 2025
@gsteel gsteel self-assigned this Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b2d072d) to head (00733df).

Additional details and impacted files
@@             Coverage Diff             @@
##               1.8.x      #153   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        92        92           
===========================================
  Files             14        14           
  Lines            367       367           
===========================================
  Hits             367       367           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsteel gsteel changed the base branch from 1.8.x to 1.7.x January 31, 2025 16:18
@gsteel gsteel merged commit 8c8ef05 into 1.7.x Jan 31, 2025
30 checks passed
@gsteel gsteel deleted the actually-remove-symfony-http-client branch January 31, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant