MS130-48P Support #3669
Open
MS130-48P Support #3669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8P device type. It was not known that this was something that would be run as a new contributor. Will make changes to run yamllint on every commit.
There was a problem hiding this comment.
Pull Request Overview
Adds device type configuration for the Cisco Meraki MS130-48P network switch to support device type definitions in what appears to be a network device inventory system.
- Adds complete YAML configuration for MS130-48P with 48 PoE ports, 4 SFP ports, and management interface
- Includes physical specifications (weight, dimensions, power requirements)
- Defines all network interfaces with appropriate PoE capabilities
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+17
to
+208
| - name: Port 1 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 2 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 3 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 4 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 5 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 6 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 7 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 8 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 9 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 10 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 11 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 12 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 13 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 14 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 15 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 16 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 17 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 18 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 19 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 20 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 21 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 22 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 23 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 24 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 25 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 26 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 27 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 28 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 29 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 30 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 31 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 32 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 33 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 34 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 35 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 36 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 37 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 38 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 39 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 40 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 41 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 42 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 43 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 44 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 45 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 46 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 47 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt | ||
| - name: Port 48 | ||
| type: 1000base-t | ||
| poe_mode: pse | ||
| poe_type: type3-ieee802.3bt |
There was a problem hiding this comment.
The 48 port definitions contain significant code duplication. Consider using YAML anchors and references to reduce repetition and improve maintainability. For example, define a base port configuration with an anchor and reference it for each port while only specifying the unique name.
Suggested change
| - name: Port 1 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 2 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 3 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 4 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 5 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 6 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 7 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 8 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 9 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 10 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 11 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 12 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 13 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 14 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 15 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 16 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 17 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 18 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 19 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 20 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 21 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 22 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 23 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 24 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 25 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 26 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 27 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 28 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 29 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 30 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 31 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 32 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 33 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 34 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 35 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 36 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 37 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 38 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 39 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 40 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 41 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 42 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 43 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 44 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 45 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 46 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 47 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - name: Port 48 | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - &base_port | |
| type: 1000base-t | |
| poe_mode: pse | |
| poe_type: type3-ieee802.3bt | |
| - <<: *base_port | |
| name: Port 1 | |
| - <<: *base_port | |
| name: Port 2 | |
| - <<: *base_port | |
| name: Port 3 | |
| - <<: *base_port | |
| name: Port 4 | |
| - <<: *base_port | |
| name: Port 5 | |
| - <<: *base_port | |
| name: Port 6 | |
| - <<: *base_port | |
| name: Port 7 | |
| - <<: *base_port | |
| name: Port 8 | |
| - <<: *base_port | |
| name: Port 9 | |
| - <<: *base_port | |
| name: Port 10 | |
| - <<: *base_port | |
| name: Port 11 | |
| - <<: *base_port | |
| name: Port 12 | |
| - <<: *base_port | |
| name: Port 13 | |
| - <<: *base_port | |
| name: Port 14 | |
| - <<: *base_port | |
| name: Port 15 | |
| - <<: *base_port | |
| name: Port 16 | |
| - <<: *base_port | |
| name: Port 17 | |
| - <<: *base_port | |
| name: Port 18 | |
| - <<: *base_port | |
| name: Port 19 | |
| - <<: *base_port | |
| name: Port 20 | |
| - <<: *base_port | |
| name: Port 21 | |
| - <<: *base_port | |
| name: Port 22 | |
| - <<: *base_port | |
| name: Port 23 | |
| - <<: *base_port | |
| name: Port 24 | |
| - <<: *base_port | |
| name: Port 25 | |
| - <<: *base_port | |
| name: Port 26 | |
| - <<: *base_port | |
| name: Port 27 | |
| - <<: *base_port | |
| name: Port 28 | |
| - <<: *base_port | |
| name: Port 29 | |
| - <<: *base_port | |
| name: Port 30 | |
| - <<: *base_port | |
| name: Port 31 | |
| - <<: *base_port | |
| name: Port 32 | |
| - <<: *base_port | |
| name: Port 33 | |
| - <<: *base_port | |
| name: Port 34 | |
| - <<: *base_port | |
| name: Port 35 | |
| - <<: *base_port | |
| name: Port 36 | |
| - <<: *base_port | |
| name: Port 37 | |
| - <<: *base_port | |
| name: Port 38 | |
| - <<: *base_port | |
| name: Port 39 | |
| - <<: *base_port | |
| name: Port 40 | |
| - <<: *base_port | |
| name: Port 41 | |
| - <<: *base_port | |
| name: Port 42 | |
| - <<: *base_port | |
| name: Port 43 | |
| - <<: *base_port | |
| name: Port 44 | |
| - <<: *base_port | |
| name: Port 45 | |
| - <<: *base_port | |
| name: Port 46 | |
| - <<: *base_port | |
| name: Port 47 | |
| - <<: *base_port | |
| name: Port 48 |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the Meraki MS130-48P Device in the Cisco MS130-48P Device. I may also add more of these, as there are about 8 or 10 models in this product line. See:
https://documentation.meraki.com/MS/MS_Overview_and_Specifications/MS130_Datasheet
Currently, there is only the 12X in the tree.