Skip to content

Add "airflow" and "profile" to moduletype test #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add "airflow" and "profile" to moduletype test #3364

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6875e53
Adding airflow to moduletype test (useful for fan and hot plug power …
iriseden Jul 31, 2025
b819068
Adding profile to moduletype test (introduced in netbox v4.3)
iriseden Jul 31, 2025
7a6fb6b
Merge branch 'master' into patch-test
harryajc Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions schema/moduletype.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
"part_number": {
"type": "string"
},
"airflow": {
"$ref": "urn:devicetype-library:generated-schema#/definitions/airflow"
},
"weight": {
"$ref": "urn:devicetype-library:reusable#/definitions/weight"
},
Expand Down Expand Up @@ -71,6 +74,9 @@
},
"comments": {
"type": "string"
},
"profile": {
Copy link
Collaborator

@harryajc harryajc Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add the airflow, however the profile option will require some more work

Copy link
Contributor Author

@iriseden iriseden Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, what kind of fix would you like? The problem with profile is that it is not standard and can be defined by the user.

Copy link
Collaborator

@harryajc harryajc Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First we would only support the default netbox profiles in this repo, secondly I was having a look the other day, but still not quite sure how the profile attributes are imported/or if that is even possible at this stage, I know in 4.3.4 they added support for importing the module profiles themselves, but currently don't see any information on importing the attributes

Copy link
Contributor Author

@iriseden iriseden Aug 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have no idea if we can import the attributes, I'll test it. Regarding the default profiles, I'll correct the commit.

"type": "string"
}
},
"required": ["manufacturer", "model"],
Expand Down
Loading