-
-
Notifications
You must be signed in to change notification settings - Fork 972
Change NETBIRD_SIGNAL_PORT mapping from 80 to 10000 #4918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This update aligns the template with the actual behavior of the Signal service and the official NetBird documentation.
WalkthroughThe Signal service port mapping in the Docker Compose template is updated from host port 80 to port 10000. The container port is changed from 80 to 10000, and the environment variable Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug in the advanced-setup docker-compose template where the Signal service port mapping was incorrectly configured. The Signal container, when running with TLS certificates (as configured in this template), listens on port 443 (main HTTP/gRPC multiplexed server) and port 10000 (legacy gRPC compatibility port), but not on port 80. The previous mapping $NETBIRD_SIGNAL_PORT:80 would fail because no service listens on port 80 inside the container when TLS is enabled. The fix changes the mapping to $NETBIRD_SIGNAL_PORT:10000, which correctly maps to the legacy gRPC port that the Signal service actually listens on.
Key changes:
- Updated Signal service port mapping from port 80 to port 10000 in the docker-compose template
- Aligns with the default value of
NETBIRD_SIGNAL_PORT=10000configured inbase.setup.env - Ensures the Signal service is accessible as expected by the management server configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.



This update aligns the template with the actual behavior of the Signal service and the official NetBird documentation.
Describe your changes
The advanced-setup docker-compose.yml template incorrectly mapped:
However, the netbird-signal container listens on port 10000 internally.
This mismatch caused external Signal connections to fail unless users manually adjusted their NAT/firewall rules or remapped the port.
The update changes the port mapping to:
This ensures correct behavior out of the box and makes the template consistent with the actual service configuration and official documentation.
Issue ticket number and link
N/A — Bug discovered during advanced setup deployment.
(If an issue is later opened, it can be added here.)
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
N/A
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.