Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

🐛 ⚡️ "createdAt" -> "created_at", remove intermediary file save #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TTtie
Copy link

@TTtie TTtie commented Aug 30, 2020

This PR:

  • fixes issues with looking up the latest tweets of an user (the "createdAt" field is snakecase according to Twitter dev docs)
  • improves speed of posting to Instagram by passing the buffer from the underlying browser library straight to the API.

@vercel
Copy link

vercel bot commented Aug 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nestdotland/tweetshot/i2qltvesi
✅ Preview: Failed

[update for 4b0a66b failed]

Copy link
Member

@t8 t8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for fixing this. I'm not sure what our future plans with this repo are yet, but this is a step in a nice direction!

CC @maximousblk, @divy-work

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm not sure about the project's future too, if we can get this working that'd be awesome!

@TTtie
Copy link
Author

TTtie commented Sep 1, 2020

Might as well fix the scheduled CI during today, as that seems to be a bit malformed as well, please don't merge yet

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants