-
Notifications
You must be signed in to change notification settings - Fork 391
Disentangle kernel-manager include tree #3544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JanVogelsang
wants to merge
96
commits into
nest:master
Choose a base branch
from
JanVogelsang:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14,578
−12,753
Open
Changes from 8 commits
Commits
Show all changes
96 commits
Select commit
Hold shift + click to select a range
f4b4941
Fixed horrible kernel_manager singleton design and cleaned up all cir…
JanVogelsang 4d545f5
Delete models/quantal_stp_synapse_impl.h
JanVogelsang 649a448
Made previously non-inlinable functions inline
JanVogelsang 390064e
Added static modifier
JanVogelsang d3e0232
Merge branch 'master' of github.com:JanVogelsang/nest-simulator into …
JanVogelsang 1eded20
Simplified get_process_id_of_node_id implementation
JanVogelsang 98c6275
Fixed remaining bugs
JanVogelsang a63d91c
Removed nest_impl.h
JanVogelsang 957b2f3
Moved from a composite singleton to inline globals
JanVogelsang 27358c0
Minimized layer_impl.h
JanVogelsang d85b30e
Minimized layer_impl.h
JanVogelsang cd6271f
Update models/CMakeLists.txt
JanVogelsang 6ebf55f
Fixed cherry-pick issue
JanVogelsang 9884718
Fixed non-MPI version
JanVogelsang 0f6edd9
Merge branch 'master' of github.com:JanVogelsang/nest-simulator into …
JanVogelsang 691c39b
Update models/CMakeLists.txt
JanVogelsang 4f102e1
Fixed non-MPI version
JanVogelsang 076e11a
Fixed conngen
JanVogelsang 0313d49
Fixed sonata
JanVogelsang e2ae1f3
Fixed conngen
JanVogelsang e02482f
Fixed sonata
JanVogelsang 5c54119
Fixed sionlib
JanVogelsang 508e349
Fixed sionlib
JanVogelsang ba7cfc6
Attempting to fix macos issue
JanVogelsang 67f510f
Changed manager access syntax
JanVogelsang 5f14394
Merge branch 'nest-master-inline' into nest-master
JanVogelsang cd959d3
Partially migrate definitions from headers
FinnBurkhardt 050b301
Merged master
JanVogelsang 545e34f
Merge remote-tracking branch 'nest-master/master' into nest-master
JanVogelsang 95946a6
Attempting to fix weird compiler issue in testsuite
JanVogelsang 8a65936
Attempting to fix weird compiler issue in testsuite
JanVogelsang b3441fd
Revert "Partially migrate definitions from headers"
FinnBurkhardt b0ebe97
Reapply "Partially migrate definitions from headers"
FinnBurkhardt 95abad7
Update nestkernel/layer_impl.h
JanVogelsang 3030c8a
Update nestkernel/layer_impl.h
JanVogelsang 79b3dae
correct minor mistakes
FinnBurkhardt 649c09a
Move inlines from clopath_archiving_node
FinnBurkhardt b43e26d
Move inlined functions from archiving_node
FinnBurkhardt 4d3a0af
Move inlined functions from common_properties_hom_w
FinnBurkhardt cb411c9
Move inlined functions from common_synapse_
FinnBurkhardt b5ed1c8
Move inlined functions from conn_builder_factory
FinnBurkhardt bfec935
Add new cpp files to CMakeLists
FinnBurkhardt 06dda40
Move inlined functions from conn_builder.h
FinnBurkhardt 361f5b1
Move inlined methods from conn_parameter.h
FinnBurkhardt ba3f0b9
Move inlined functions from delay_checker.h
FinnBurkhardt cc367ea
Move inlined functions from deprecation_warning.h, device_node.h and …
FinnBurkhardt e0df1b5
Move inlined functions from event_delivery_manager.h
FinnBurkhardt ecb4e92
Move inlined functions from event.h
FinnBurkhardt 28a6ec4
Move inlined functions from io_manager, kernel_manager, layer.h and m…
FinnBurkhardt 29c3adc
Move inlined functions from model.h, modelrange_manager.h, modelrange.h
FinnBurkhardt ba25cb3
Move inlined functions from mpi_manager.h
FinnBurkhardt 58e0901
Move inliend functions from nest_time.h and nestmodule.h
FinnBurkhardt b1acd2a
Move inlined function from node_collection
FinnBurkhardt 9ed6513
Move inlined functions from node_manager
FinnBurkhardt 0bc3cea
Move inliend methods from node.h and ntree.h
FinnBurkhardt dafb1dd
Move inlined methods from parameters.h and per_thread_bool_indicator.h
FinnBurkhardt 772bc0e
Move inlined functions from proxynode.h pseudo_recording_device.h and…
FinnBurkhardt dde3882
Move inlined functions from recording_backed_sionlib.h, ring_buffer.h…
FinnBurkhardt ff56f99
Fix namespace error
FinnBurkhardt c9b4f0d
Move inlined functions from slice_ring_buffer.h, source_table.h, sour…
FinnBurkhardt 0829807
Move inlined functions from sparse_node_array.h, spatial.h and spike_…
FinnBurkhardt f63e5f1
Move inlined functions from structural_plasticity_node.h, stimulation…
FinnBurkhardt 6e08841
Move inlined functions from syn_id_delay.h and synaptic_element.h
FinnBurkhardt 4664021
Move inliend methods from target_data.h, target_identifier.h, target_…
FinnBurkhardt c7867fd
Move inlined functions from target_table.h, target.h and vp_manager.h
FinnBurkhardt 99b4aa0
Move inlined methods from source_table_position.h
FinnBurkhardt f721e79
Move template functions from conn_builder_factory.h, connection.h, co…
FinnBurkhardt f97dce1
Move template functions from eprop_archiving_node_readout.h and eprop…
FinnBurkhardt b3cf3d2
Move template functions from eprop_archiving_node.h, event_delivery_m…
FinnBurkhardt db56a23
Move template functions from event_delivery_manager.h, genericmodel.h…
FinnBurkhardt fdd0162
Move template functions rom mask_impl.h, mask.h, model_manager.h, mpi…
FinnBurkhardt df829ce
Fix model manager
FinnBurkhardt 6c9dcd2
Formatting
FinnBurkhardt 09a5b40
Merge remote-tracking branch 'nest-master/master' into move-funcs-to-cpp
JanVogelsang 9cfcbe5
Now fully separated header and impl files
JanVogelsang 0e2de08
Fixed missing include
JanVogelsang 03041b6
Merge pull request #1 from JanVogelsang/finn-pr
FinnBurkhardt cf77eab
Merge remote-tracking branch 'nest-master/master' into move-funcs-to-cpp
JanVogelsang 82cd774
Merge remote-tracking branch 'origin/master' into move-funcs-to-cpp
JanVogelsang d1d6667
Fixed copyright headers
JanVogelsang 8644483
Fixed line endings
JanVogelsang de1ff08
Fixed issues when compiling without MPI
JanVogelsang e4e4ff0
Fixed issues when compiling with debugging symbols
JanVogelsang 37611c0
Fixed issues when compiling with debugging symbols
JanVogelsang 34a3801
Fixed typo
JanVogelsang bbc8b67
Fixed issues when compiling with debugging symbols
JanVogelsang cedacee
Fixed issues when compiling with debugging symbols
JanVogelsang 79c53f5
Fixed linker issues
JanVogelsang b28038c
Fixed sonata missing includes
JanVogelsang aef9ecc
Fixed missing include
JanVogelsang f5c327f
Fixed missing music include
JanVogelsang da8d884
Fixed missing music include
JanVogelsang b3706ed
Merge branch 'nest:master' into master
JanVogelsang c6e9435
Merge remote-tracking branch 'nest-master/master' into kernel-manager…
JanVogelsang a870f52
Merged master
JanVogelsang 68f110e
Post-merge cleanup
JanVogelsang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
632 changes: 457 additions & 175 deletions
632
doc/htmldoc/developer_space/guidelines/coding_guidelines_cpp.rst
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,9 +22,6 @@ | |
|
|
||
| #include "cm_default.h" | ||
|
|
||
| // Includes from nestkernel: | ||
| #include "nest_impl.h" | ||
|
|
||
| namespace nest | ||
| { | ||
| void | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.