-
Notifications
You must be signed in to change notification settings - Fork 381
Fix merging responses in nest-server-mpi
#3492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
78404ae
to
909e5eb
Compare
nest-server-mpi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 The logic seems perfectly correct to me. Robustness could be increased by additional checks of values and lists. But only if necessary.
I am working on better solution of combine function. Thank you for the patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me, but I think docstrings for the new methods would be an advantage for long-term maintenance of the code.
When executing simulation via
nest-server-mpi
, the result seems not correctly.In fact, when using a number of processes greater than 1, lets say an example
np = 3
.It shows only activity of each 3rd neuron.
It seems that we need to merge the responses of
nest-server-mpi
.With this PR, NEST Desktop shows activity of all neurons executed on
nest-server-mpi
.