Fix warnings regarding int-type variables #3026
Conversation
terhorstd
added
S: Normal
There was a problem hiding this comment.
Looks good to me, as long as the changes by @heplesser get integrated.
|
@muffgaga , this seems to be basically complete except for the suggested change. Could you also add a description to this PR? The current sentence seems to have little relation to what your proposed change is. |
This commit fixes build-time warnings from the compiler that I encountered in my local build. It cleans up comparisons between unsigned size-like types (e.g. size_t) and signed indices (long/int).
Done, description also added to the commit (wasn't sure if adding text to the PR-opening comment is sufficient). |
|
@muffgaga, could you re-trigger the CI? I don't have the buttons in this PR. Either Github removed them, the force-push broke something, or you have some settings in your branch preventing me from doing so. |
|
@muffgaga @terhorstd Strange that the re-run button has disappeared, but maybe this is because a long time has passed since the last time CI was run for this PR (the logs have been deleted). Maybe the easiest way to run the tests again would be to merge master into the branch and then push that back to Github. |
This PR fixes build-time warnings from the compiler that I encountered in my local build.
It cleans up comparisons between unsigned size-like types (e.g.
size_t) and signed indices (long/int).Sorry for the close (of #3025)/reopen, github reacted weird when I pushed with full reference name
refs/heads/fix_warnings2…