Skip to content

refactor: ensure transporter.verify returns a promise #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahdichaari01 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: ensure transporter.verify returns a promise #1145

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30a4b9f
refactor: Handle optional transporter.verify gracefully
mahdichaari01 Mar 21, 2024
769a94d
Update mailer.service.ts
mahdichaari01 Mar 22, 2024
3dcd89c
Update mailer.service.ts
mahdichaari01 Mar 22, 2024
914da9a
Update mailer.service.ts
mahdichaari01 Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/mailer.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,11 @@ export class MailerService {

private verifyTransporter(transporter: Transporter, name?: string): void {
const transporterName = name ? ` '${name}'` : '';
transporter.verify()
.then(() => this.mailerLogger.debug(`Transporter${transporterName} is ready`))
.catch((error) => this.mailerLogger.error(`Error occurred while verifying the transporter${transporterName}: ${error.message}`));

// wrap value in a promise to ensure then is always defined
new Promise(()=>transporter?.verify())
.then(() => this.mailerLogger.log(`Transporter${transporterName} is ready`))
.catch((error) => this.mailerLogger.log(`Error occurred while verifying the transporter${transporterName}}: ${error.message}`));
Comment on lines +111 to +112
Copy link

@Clashsoft Clashsoft Apr 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the log level (debug/error -> log)?

Copy link
Author

@mahdichaari01 mahdichaari01 Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, the point here is to just wrap it in a promise and keep the default behavior

}

public async verifyAllTransporters() {
Expand Down