Implemented a new resource class for Openshift virtualization #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikolla
approved these changes
Apr 8, 2025
QuanMPhm
force-pushed
the
add_vm_gpu_quotas
branch
from
7edfc77 to
76c11c9
Compare
naved001
reviewed
Apr 9, 2025
QuanMPhm
force-pushed
the
add_vm_gpu_quotas
branch
from
76c11c9 to
a1e9877
Compare
naved001
approved these changes
Apr 11, 2025
QuanMPhm
force-pushed
the
add_vm_gpu_quotas
branch
2 times, most recently
from
3aaaad7 to
e9f1942
Compare
|
@naved001 @knikolla The CI error is caused by the fact that even though this PR updated the version pin for the account manager, the account manager's deployment manifest still uses an ancient image version. The exact reason why an error occured is because this PR introduced new quota attributes, and the account manager restricts quota attributes to a certain list (and this is, of course, out-dated) I guess this means we can either make a new release of the account manger image, or update the CI file in this repo to build its own image of the account manager. I'll wait for your opinions before moving forward. |
|
@QuanMPhm I made a new release of |
QuanMPhm
force-pushed
the
add_vm_gpu_quotas
branch
from
e9f1942 to
579c862
Compare
QuanMPhm
force-pushed
the
add_vm_gpu_quotas
branch
from
579c862 to
2d0624e
Compare
QuanMPhm
force-pushed
the
add_vm_gpu_quotas
branch
2 times, most recently
from
d748204 to
abe82b6
Compare
- The CI file has been changed to also run the openshift vm function test. - New VM-specific GPU attributes have been added - `add_openshift_resource` now has an `vm` option to create Openshift Virtualization resources - The `QUOTA_KEY_MAPPING` in `openshift.py` has been moved into the allocator class, which is then overidden by the Openshift VM allocator
QuanMPhm
force-pushed
the
add_vm_gpu_quotas
branch
from
abe82b6 to
4e216a5
Compare
|
@knikolla 🔥 ✍️ 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes nerc-project/operations#820. This PR consists of 2 commits. The first one updates the account manager pin, and the second contains the implementation for the new resource class. More details in the commit message.