Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct version to v4.0.0 #226

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

debeaueric
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for nephio-r4 ready!

Name Link
🔨 Latest commit cefbf1f
🔍 Latest deploy log https://app.netlify.com/sites/nephio-r4/deploys/67d88e0ad18ab300081140d3
😎 Deploy Preview https://deploy-preview-226--nephio-r4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -33,7 +33,7 @@ This component is a controller for applying configuration to routers and
switches.

```bash
kpt pkg get --for-deployment https://github.com/nephio-project/catalog.git/nephio/optional/network-config@origin/v3.0.0
kpt pkg get --for-deployment https://github.com/nephio-project/catalog.git/nephio/optional/network-config@origin/v4.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am leaning towards removing the vX.Y.Z refs in the docs altogether and just using a place holder. It would require some refactoring and an explainer regarding the released versions available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should go with this change from @debeaueric for now?

@efiacor
Copy link
Collaborator

efiacor commented Apr 1, 2025

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Apr 1, 2025
Copy link
Contributor

nephio-prow bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Apr 1, 2025
@nephio-prow nephio-prow bot merged commit 9562376 into nephio-project:R4 Apr 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants