BUGFIX: add feedback to switch to new document in tree on cut and copy #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pKallert
changed the title
pKallert
force-pushed
the
bugfix/redirect-copy-cut-in-document-tree
branch
from
b9f9c08 to
1f3f32d
Compare
mhsdesign
reviewed
Feb 21, 2025
| @@ -36,6 +36,7 @@ protected function finish(NodeInterface $node): void | |||
| $updateNodeInfo->setNode($node); | |||
| $updateNodeInfo->recursive(); | |||
| $this->feedbackCollection->add($updateNodeInfo); | |||
| $this->addNodeCreatedFeedback($this->getSubject()); | |||
There was a problem hiding this comment.
why do we need this line here? Rest looks understandable:)!
There was a problem hiding this comment.
This will select the new document as active, basically does the same as Redirect (from a UI behavior standpoint).
Fun fact: This is already included in Neos 9, but there the AbstractCopy does not exist anymore: https://github.com/neos/neos-ui/blob/9.0/Classes/Domain/Model/Changes/CopyBefore.php#L88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3917
What I did
When using cut/copy in the document tree, the user is not automatically redirected to the "new" page.
How I did it
To keep it consistent with all other operations in the content/document tree I added feedback in the operations that will lead to the user being on the new page
How to verify it
When using cut/copy/create in both the document and content tree, the user is always redirected to the "new" node.