-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom exceptions for better error-handling #46
Conversation
…for Weaviate retriever
d5bb2a1
to
5ea11c9
Compare
18a59cd
to
a035b00
Compare
@CodiumAI-Agent /update_changelog |
Changelog updates: 🔄 2024-05-29Added
Changed
Fixed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! (just double check the print in my comments above if you can, the rest is very minor)
Description
This PR adds custom exceptions to replace the usage of
ValueError
in various places as they were unambiguous and not informative to the user. Here is a way to think about the added exceptions:__init__()
method of retrievers..search()
method of retrievers.VectorSearchRecord
. This will probably change with Retriever results #45Additionally, new types are specified for the
WeaviateNeo4jRetriever
to be used for data validation. This enables it to raise exceptions similarly to the Neo4j retrievers.The documentation is updated to include the errors.
Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):