Remove torch from pyproject's dev dependencies #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtai
force-pushed
the
willtai/remove-torch-from-pyproject
branch
from
7c28cf6 to
bc89563
Compare
stellasia
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts a previous change where we install
torchfrom a wheel file. The original change was meant to take into account Macbook users with Python running on Rosetta but this has become too restrictive as it require specifically Python 3.11. This will undo that change.Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
poetry lockandpoetry installworks locally.Checklist
The following requirements should have been met (depending on the changes in the branch):