Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sentence-transformers embeddings #40

Merged
merged 7 commits into from
May 28, 2024
Merged

Add sentence-transformers embeddings #40

merged 7 commits into from
May 28, 2024

Conversation

jonbesga
Copy link
Contributor

No description provided.

@jonbesga jonbesga force-pushed the jonbesga/add-sentence-transformers branch from 0093ed3 to 5d90ff7 Compare May 23, 2024 13:52
@oskarhane
Copy link
Member

Would this change the sentence-transformers to be a regular dependency rather than a dev-dependency?
Or should we add it to the extras?
My concern is package size / installation time.

@jonbesga
Copy link
Contributor Author

Would this change the sentence-transformers to be a regular dependency rather than a dev-dependency? Or should we add it to the extras? My concern is package size / installation time.

Is not. You need to install it separately precisely because I wanted to avoid the size issue

@jonbesga jonbesga requested a review from a team May 23, 2024 14:26
@jonbesga jonbesga merged commit 96cc5f7 into main May 28, 2024
9 checks passed
@jonbesga jonbesga deleted the jonbesga/add-sentence-transformers branch May 28, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtai willtai willtai left review comments

@stellasia stellasia stellasia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonbesga @oskarhane @stellasia @willtai