-
Notifications
You must be signed in to change notification settings - Fork 36
Add errors for unsupported combinations with path modes #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dogofbrian. I added some comments.
| = 42N60 | ||
|
|
||
| == Status description | ||
| error: syntax error or access rule violation - unsupported combination of match mode and path mode. REPEATABLE ELEMENTS with `{ <<pathMode>> }` path mode is not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is REPEATABLE ELEMENTS capitalized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add an explanation/ example scenario for each of the errors? See 22N71, 22N69, 22NAB, 42I64, and many more for inspiration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REPEATABLE ELEMENTS are capitalised because they are keywords.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the three new / altered codes, I have added examples and, where I could make it work, possible solutions
e48a10c to
7c955d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found a typo. Otherwise, looks good.
Co-authored-by: Reneta Popova <[email protected]>
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
New error codes (and one message update) for path mode semantic checking