Skip to content

Conversation

@anderson4j
Copy link
Collaborator

@anderson4j anderson4j commented Oct 23, 2025

Fixes the issue mentioned here
Before we converted to js-numbers and integers were printed as "4" instead of "4.0" which is what the Point object on the driver has, and also what cypher shell prints.

Switches so we just do point.toString() on the driver Point object we get.

Coordinates like 4 become 4.0 in the printed string
image

The driver still strips excessive 0s, but leave the last one, like:
image
Same as in cypher shell
image

2D looks fine too:
image

Edit: I missed that the parenthesis is missing in the driver output. Max is looking into if it can be changed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025

⚠️ No Changeset found

Latest commit: 2fa77f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@anderson4j anderson4j added the bug Something isn't working label Oct 23, 2025
}
if (typeof property === 'bigint') {
if (
typeof property === 'boolean' ||
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this look compared to a sequence of if statements. In general the logic would be altered a bit with moving the order of the checks, but the re-ordered conditions are anyway mutually exclusive (never true on both type=string AND type=point), so in this case we are safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant