Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use poetry as the build tool and apply linting & styling #4

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Use poetry as the build tool and apply linting & styling #4

merged 5 commits into from
Nov 29, 2023

Conversation

ali-ince
Copy link
Contributor

This PR;

  • switches to poetry for builds and dependency management
  • uses flake8 and mypy for linting, styling and type checking
  • updates docker image to make use of poetry and google recommended approach

@ali-ince ali-ince requested a review from a team as a code owner November 28, 2023 13:28
venikkin
venikkin requested changes Nov 28, 2023
View reviewed changes
Copy link

@venikkin venikkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few instances with commented code is not quite clear to me if these were accidental or intended.

src/templates/bq_client.py Outdated Show resolved Hide resolved
venikkin
venikkin reviewed Nov 28, 2023
View reviewed changes
src/templates/bigquery.py Outdated Show resolved Hide resolved
@ali-ince ali-ince requested a review from venikkin November 29, 2023 11:02
@ali-ince ali-ince merged commit 9a2ef02 into main Nov 29, 2023
4 checks passed
@ali-ince ali-ince deleted the build-use-poetry branch November 29, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venikkin venikkin venikkin approved these changes

@fbiville fbiville Awaiting requested review from fbiville fbiville is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ali-ince @venikkin