Fix stray HTML tags. #324
Open
Fix stray HTML tags. #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
recrwplay
reviewed
Apr 17, 2025
| {{!-- <img class="navbar-logo" src="https://dist.neo4j.com/wp-content/uploads/20230926084108/Logo_FullColor_RGB_TransBG.svg" alt="{{ site.title }}" /> --}} | ||
| <a href="/graphacademy/online-training/" class="navbar-item no-left-padding page-name-white" aria-label="GraphAcademy"> | ||
| GraphAcademy | ||
| </a> | ||
| {{else if (eq page.attributes.theme "graphgists")}} | ||
| <img class="navbar-logo" src="https://dist.neo4j.com/wp-content/uploads/20231023102534/neo4j-logo.svg" alt="{{ site.title }}" /> |
There was a problem hiding this comment.
Content is still published with themes that have a dark header background so we do still need to use this image
eg
- https://neo4j.com/graphgists/ (graphgists theme)
- https://neo4j.com/developer/genai-ecosystem/ (developer theme)
- https://neo4j.com/developer/kb (kb theme)
There was a problem hiding this comment.
Ouch, thanks. The commented out lines probably confused me.
There was a problem hiding this comment.
Yeah, all the different themes and layouts are confusing for sure. There's probably files in there that should be deleted as well, but I keep thinking - is it worth the effort, or are we better off starting from scratch with a new version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pages currently have two stray tags - major browsers seem to render them well anyway, but there's no good reason to rely on that.
To fix the missing closing
</a>in the logo link, I also incorporated the fact that we've retired developer guides, so that an extra logo (white logo on black background) is not needed anymore. If this assumption is not valid, I'll revise.