-
Notifications
You must be signed in to change notification settings - Fork 71
Added cypher support #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
public Traverser traverse( Order traversalOrder, StopEvaluator stopEvaluator, | ||
ReturnableEvaluator returnableEvaluator, Object... relationshipTypesAndDirections ) | ||
{ | ||
return OldTraverserWrapper.traverse( this, traversalOrder, stopEvaluator, returnableEvaluator, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imho this old-traverser does not the correct thing as it would execution the traversal over the wire for each step, it should rather use RestTraversal.description() to build up the query (in a similar fashion), which would be executed on the server-side.
Did you look into rewriting this so that it creates a correct rest-traversal description and sends it over to the server? |
Hi, Yes I did tried, I emailed to you on Apr 21, 2012 at 7:07 PM ,anyway. Can you please let me know if we should try to something similar to As I tried something but finally stuck between _org.neo4j.graphdb.Traverser_and Kalyan On Fri, May 4, 2012 at 7:32 PM, Michael Hunger <
Thanks and Regards |
Have you looked into upgrading neoclipse to the new traversal API ? (Or even better use cypher in these places) That would help a lot. Michael |
No, But that is in my road map. I will start on this soon. Kalyan On Sat, May 5, 2012 at 9:36 AM, Michael Hunger <
Thanks and Regards |
Nice Impl, but it still does the filtering on the client side, right? |
Yes, partly. I tweaked it a little bit to support neo4j-scala and its typed traverser. See the tests here:
|
Hi,
I have added few method in java-rest-binding to make it work with neoclipse.
Please find my changes and let me know if there is something wrong.