Skip to content

Added cypher support #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nrkkalyan
Copy link

Hi,

I have added few method in java-rest-binding to make it work with neoclipse.
Please find my changes and let me know if there is something wrong.

public Traverser traverse( Order traversalOrder, StopEvaluator stopEvaluator,
ReturnableEvaluator returnableEvaluator, Object... relationshipTypesAndDirections )
{
return OldTraverserWrapper.traverse( this, traversalOrder, stopEvaluator, returnableEvaluator,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho this old-traverser does not the correct thing as it would execution the traversal over the wire for each step, it should rather use RestTraversal.description() to build up the query (in a similar fashion), which would be executed on the server-side.

@jexp
Copy link
Member

jexp commented May 4, 2012

Did you look into rewriting this so that it creates a correct rest-traversal description and sends it over to the server?

@nrkkalyan
Copy link
Author

Hi,

Yes I did tried, I emailed to you on Apr 21, 2012 at 7:07 PM ,anyway.
Here is my findings,

Can you please let me know if we should try to something similar to
OldTraverserWrapper but using RestTraversal.description() or something
different.

As I tried something but finally stuck between _org.neo4j.graphdb.Traverser_and
org.neo4j.graphdb.traversal.Traverser
Since node.traverse() returns org.neo4j.graphdb.Traverser, *I am not
getting what to modify.

Kalyan
*

On Fri, May 4, 2012 at 7:32 PM, Michael Hunger <
[email protected]

wrote:

Did you look into rewriting this so that it creates a correct
rest-traversal description and sends it over to the server?


Reply to this email directly or view it on GitHub:
#3 (comment)

Thanks and Regards
N Radhakrishna Kalyan

@jexp
Copy link
Member

jexp commented May 5, 2012

Have you looked into upgrading neoclipse to the new traversal API ? (Or even better use cypher in these places)

That would help a lot.

Michael

@nrkkalyan
Copy link
Author

No, But that is in my road map. I will start on this soon.

Kalyan

On Sat, May 5, 2012 at 9:36 AM, Michael Hunger <
[email protected]

wrote:

Have you looked into upgrading neoclipse to the new traversal API ? (Or
even better use cypher in these places)

That would help a lot.

Michael


Reply to this email directly or view it on GitHub:
#3 (comment)

Thanks and Regards
N Radhakrishna Kalyan

@jexp
Copy link
Member

jexp commented May 10, 2012

Nice Impl, but it still does the filtering on the client side, right?

@FaKod
Copy link

FaKod commented May 10, 2012

Yes, partly.

I tweaked it a little bit to support neo4j-scala and its typed traverser.

See the tests here:
https://github.com/FaKod/neo4j-scala/blob/AddNodeTraverse/src/test/scala/org/neo4j/scala/unittest/TypedTraverserRESTSpec.scala
Am 10.05.2012 18:38 schrieb "Michael Hunger" <
[email protected]

:

Nice Impl, but it still does the filtering on the client side, right?


Reply to this email directly or view it on GitHub:
#3 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants