Skip to content

Conversation

@shargon
Copy link
Member

@shargon shargon commented Nov 14, 2025

Description

This is one of the steps to archive the flat rewards, first of all committe al CN will earn the same.

Note: Wait for a valid Proof of Node

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Testing
  • Run Application
  • Local Computer Tests
  • No Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon changed the base branch from master to master-n3 November 14, 2025 18:19
@shargon shargon added Waiting for Review NGD Review This pr is an UT/Benchmark PR, NGD can review. neo3 labels Nov 14, 2025
@shargon shargon changed the title Flat rewards (21 first nodes) [N3] Flat rewards (21 first nodes) Nov 14, 2025
@shargon shargon added the Blocked This issue can't be worked at the moment label Nov 14, 2025
@shargon shargon marked this pull request as ready for review November 14, 2025 18:23
if (withFlatRewards)
{
BigInteger voterSumRewardPerNEO = factor * voterRewardOfEachCommittee / votes;
BigInteger voterSumRewardPerNEO = voterRewardOfEachCommittee / votersCount;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another change apart of flat rewards, this also set a defined level among the committee itself

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now, @shargon, one main point to change here is not just this factor but it is the votersCount.

We should not consider votersCount for each committee reward, that is what removes the incentive for free voting.

@shargon shargon added N3 and removed neo3 labels Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked This issue can't be worked at the moment N3 NGD Review This pr is an UT/Benchmark PR, NGD can review. Waiting for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants