Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dependencies numeric_interval requires #590

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chriseng9
Copy link

@chriseng9 chriseng9 commented Jan 8, 2025

When using numeric_interval as a dependency, it fails to build as numeric/interval.hpp includes limits.h but the dependency is not set up to consume it

Error message:

external/rules_boost++non_module_dependencies+boost/libs/numeric/interval/include/boost/numeric/interval.hpp:14:10: fatal error: boost/limits.hpp: No such file or directory
   14 | #include <boost/limits.hpp>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.

@chriseng9
Copy link
Author

chriseng9 commented Jan 9, 2025

Made a change to follow the CMakeLists file for numeric interval to add the dependencies required as there is no longer a limits library

@chriseng9 chriseng9 changed the title Adds limits as a dep to numeric_interval Adds dependencies numeric_interval requires Jan 9, 2025
@nelhage nelhage enabled auto-merge (squash) January 9, 2025 18:45
@nelhage
Copy link
Owner

nelhage commented Jan 9, 2025

Working on fixing the build in #591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants