Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #19 #21

Merged
merged 1 commit into from
Oct 23, 2019
Merged

fix: #19 #21

merged 1 commit into from
Oct 23, 2019

Conversation

lxfriday
Copy link
Collaborator

@lxfriday lxfriday commented Oct 21, 2019 •
edited
Loading

ref #19

@codecov
Copy link

codecov bot commented Oct 21, 2019 •
edited
Loading

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #21   +/-   ##
====================================
  Coverage      96%   96%           
====================================
  Files           1     1           
  Lines          50    50           
  Branches       12    12           
====================================
  Hits           48    48           
  Misses          2     2
Impacted Files Coverage Δ
src/index.ts 96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2c624...cb5560d. Read the comment docs.

camsong
camsong reviewed Oct 23, 2019
View reviewed changes
Copy link
Member

@camsong camsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@camsong camsong merged commit 6d29b95 into nefe:master Oct 23, 2019
@camsong camsong mentioned this pull request Oct 23, 2019
Closed
@camsong
Copy link
Member

camsong commented Oct 23, 2019

@lxfriday Thanks for your contributions 👏 I would like to invite you to be a collaborator.
Please add my wechat tel: 13162473297

@lxfriday
Copy link
Collaborator Author

@camsong Thank you, it's an honor to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsong camsong camsong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lxfriday @camsong