update minus function, fix #3

nefe · Oct 18, 2017 · 3e1f681 · 3e1f681
1 parent 934842f
commit 3e1f681
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -32,7 +32,6 @@ function times(num1, num2) {
   return num1Changed * num2Changed / Math.pow(10, baseNum);
 }
 
-
 /**
  * 精确加法
  */
@@ -46,7 +45,7 @@ function plus(num1, num2) {
  */
 function minus(num1, num2) {
   const baseNum = Math.pow(10, Math.max(digitLength(num1), digitLength(num2)));
-  return (num1 * baseNum - num2 * baseNum) / baseNum;
+  return (times(num1, baseNum) - times(num2, baseNum)) / baseNum;
 }
 
 /**

diff --git a/test/test.spec.js b/test/test.spec.js
@@ -55,6 +55,8 @@ describe('NP.minus', () => {
   }
 
   it('can do minus operation', () => {
+    check(0.07, 0.01, 0.06);
+    check(0.7, 0.1, 0.6);
     check(1.0, 0.9, 0.1);
     check(1, 0, 1);
     check(1, -0, 1);
@@ -78,6 +80,8 @@ describe('NP.times', () => {
   }
 
   it('can do times operation', () => {
+    check(0.07, 100, 7);
+    check(0.7, 0.1, 0.07);
     check(3, 0.3, 0.9);
     check(0.362, 100, 36.2);
     check(1.1, 1.1, 1.21);