fix: Login button text invisible and navbar theme/language controls unstyled in light mode#723
Open
cosmoqain459 wants to merge 1 commit into
Open
Conversation
…nstyled in light mode
Contributor
Thanks for creating a PR for your Issue!
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fixes — Navbar UI Inconsistencies
FIxes
Default state: Button text is not visible
Hover state: Text appears only on hover
Makes login completely undiscoverable for users
Both appear as plain unstyled white boxes in light mode
Dark mode renders correctly
Breaks visual consistency of the navbar
📋 Changes Made
Bug 1 — Login Button Text Invisible by Default
The Login button text was invisible in its default state and
only appeared on hover, making it completely undiscoverable
for users without hover interaction.
Root Cause:
The
.nav-menu .btn-primaryrule was missing an explicitbackground and text-shadow, causing the button text to blend
into the navbar background in light mode.
Fix Applied (
static/css/style.css~line 512):Added explicit background gradient, border, and text-shadow
to
.nav-menu .btn-primaryto ensure text is always visible.Bug 2 — Language Selector (EN) and Theme Toggle Unstyled
The EN language dropdown and sun/moon dark mode toggle appeared
as plain unstyled white boxes in light mode, breaking visual
consistency of the navbar.
Root Cause:
.language-switcherand.theme-toggle-btnhad nonavbar-scoped styles for light mode. Dark mode rendered
correctly but light mode was missing border and background.
Fix Applied (
static/css/style.css):Added
.nav-menu-scoped styles for both controls with:[data-theme="dark"]📸 Screenshots
Light Mode — Before
Image
Light Mode — After
Image
✅ Testing Done
📁 Files Changed
static/css/style.css— 22 lines modified, 22 lines addedThe 2 failing tests (test_post_api_analyze_invalid_image and
test_post_api_analyze_rejects_mime_mismatch) are pre-existing
failures unrelated to this PR. This PR only modifies
static/css/style.css and does not touch app.py or any
backend logic.
Fixes #710