Skip to content

fix: Login button text invisible and navbar theme/language controls unstyled in light mode#723

Open
cosmoqain459 wants to merge 1 commit into
neeru24:mainfrom
cosmoqain459:fix/navbar-login-visibility-theme-toggle
Open

fix: Login button text invisible and navbar theme/language controls unstyled in light mode#723
cosmoqain459 wants to merge 1 commit into
neeru24:mainfrom
cosmoqain459:fix/navbar-login-visibility-theme-toggle

Conversation

@cosmoqain459

@cosmoqain459 cosmoqain459 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🐛 Bug Fixes — Navbar UI Inconsistencies

FIxes

  1. Login Button — Invisible Text

Default state: Button text is not visible
Hover state: Text appears only on hover
Makes login completely undiscoverable for users

  1. Language Selector (EN) + Dark/Light Mode Toggle
    Both appear as plain unstyled white boxes in light mode
    Dark mode renders correctly
    Breaks visual consistency of the navbar

📋 Changes Made

Bug 1 — Login Button Text Invisible by Default

The Login button text was invisible in its default state and
only appeared on hover, making it completely undiscoverable
for users without hover interaction.

Root Cause:
The .nav-menu .btn-primary rule was missing an explicit
background and text-shadow, causing the button text to blend
into the navbar background in light mode.

Fix Applied (static/css/style.css ~line 512):
Added explicit background gradient, border, and text-shadow
to .nav-menu .btn-primary to ensure text is always visible.


Bug 2 — Language Selector (EN) and Theme Toggle Unstyled

The EN language dropdown and sun/moon dark mode toggle appeared
as plain unstyled white boxes in light mode, breaking visual
consistency of the navbar.

Root Cause:
.language-switcher and .theme-toggle-btn had no
navbar-scoped styles for light mode. Dark mode rendered
correctly but light mode was missing border and background.

Fix Applied (static/css/style.css):
Added .nav-menu-scoped styles for both controls with:

  • Consistent border and background in light mode
  • Proper dark mode variant via [data-theme="dark"]
  • Smooth transitions for theme switching

📸 Screenshots

Light Mode — Before

Login button invisible, EN + toggle plain white boxes

Image

image

Light Mode — After

Login button clearly visible, EN + toggle properly styled

Image

image

✅ Testing Done

  • Login button text visible by default in light mode
  • Login button hover state still works correctly
  • EN selector styled consistently in light mode
  • Sun/moon toggle styled consistently in light mode
  • Dark mode toggle works correctly
  • All navbar elements consistent in both modes
  • No other styles broken

📁 Files Changed

  • static/css/style.css — 22 lines modified, 22 lines added

⚠️ Pre-existing Test Failures Note

The 2 failing tests (test_post_api_analyze_invalid_image and
test_post_api_analyze_rejects_mime_mismatch) are pre-existing
failures unrelated to this PR. This PR only modifies
static/css/style.css and does not touch app.py or any
backend logic.

Fixes #710

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Thanks for creating a PR for your Issue! ☺️

We'll review it as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

@cosmoqain459

cosmoqain459 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Hi @neeru24 and @iarmaanx .Please review this pull request which fixes issue #710 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Login button text invisible by default and EN selector/dark mode toggle unstyled in light mode navbar

1 participant