Fix SQLite concurrency for refresh rotation tests#667
Open
shreyansh-tech21 wants to merge 6 commits into
Open
Conversation
Contributor
Thanks for creating a PR for your Issue!
|
Owner
|
@shreyansh-tech21 resolve conflicts |
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # app.py # security_utils.py # services/auth_security_service.py
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves SQLite behavior for concurrent refresh-token rotation and hardens the refresh rotation tests so they match real multi-threaded use: workers run with their own Flask
app_context, tests use a shared file-backed SQLite DB (not isolated:memory:per connection), and the app configures SQLAlchemy’sBEGIN IMMEDIATEpattern on SQLite so two threads cannot both “win” the same rotation race. The concurrent test still asserts exactly one successfulrotate_refresh_tokenand oneRefreshRotationError(reuse).Related Issue
Closes #12
Changes made
sqlite_db.pywithconfigure_sqlite_immediate_transactions()(connect→isolation_level = None,begin→BEGIN IMMEDIATE) for SQLite engines only.app.pyimmediately afterdb.init_app(app)(insideapp_context()), so production and tests using SQLite get serialized writer behavior without affecting Postgres.tests/test_refresh_rotation.py:tmp_pathfile SQLite URI +db.engine.dispose()in the fixture; per-threadwith app.app_context()in concurrent workers; docstring describing threading + SQLite safety; stricter assertions on the loser (reuse).Checklist