fix: support complex extra env var map #70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two main ways to embed environment variables -
extraEnvVars
andextraEnvVarsMap
. The former is a 1:1 mapping of the environment variable structure allowing for complex values (such as a value from a secret). The latter is a map of key/value where the value is only strings.This PR allows the map method to support complex values.
The main reason for this is that you cannot combine lists via helm value merging functionality. Example:
When running
helm template . -f values.yaml -f values-prod.yaml
, the env varA_VALUE
will be excluded as the merging of the two lists resolves by taking the latter in full, since this is no way to determine which overrides the other.When using a map, however:
The merged output will be: