lesson 2 - tran dang thinh - homework #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndthang15
commented
Oct 17, 2023
Comment on lines
+1
to
+3
| DROP TYPE IF EXISTS organization_status_type; | ||
| DROP TYPE IF EXISTS user_status_type; | ||
| DROP TYPE IF EXISTS sex_type; |
Owner
Author
There was a problem hiding this comment.
Mình ko cần DROP TYPE vì script chỉ chạy 1 lần, và xóa nếu nó đang được gắn vào bảng có thể gây lỗi.
Comment on lines
+9
to
+14
| DROP TABLE IF EXISTS sso_organization; | ||
| DROP TABLE IF EXISTS sso_user; | ||
| DROP TABLE IF EXISTS sso_roles; | ||
| DROP TABLE IF EXISTS sso_user_profile; | ||
| DROP TABLE IF EXISTS sso_organization_user; | ||
| DROP TABLE IF EXISTS sso_user_role; |
Owner
Author
There was a problem hiding this comment.
Mình không nên xóa bảng, vì nếu lỡ script chạy lần 2 vì 1 lý do nào đó, có thể sẽ bị mất dữ liệu thực tế.
Chỉ cần bên dưới tạo bảng với lệnh CREATE TABLE IF NOT EXISTS là được rồi nhé.
| organization_id SERIAL PRIMARY KEY NOT NULL, | ||
| organization_name VARCHAR(255) NOT NULL, | ||
| status organization_status_type DEFAULT 'active'::organization_status_type NOT NULL, | ||
| organization_id INT NOT NULL, |
Owner
Author
There was a problem hiding this comment.
Suggested change
| organization_id INT NOT NULL, | |
| organization_id INT NOT NULL GENERATED ALWAYS AS IDENTITY, |
| date_modified TIMESTAMPTZ DEFAULT now() | ||
| postal_code VARCHAR(10), | ||
| organization_sub_name VARCHAR(10), | ||
| website_url VARCHAR(255) |
Owner
Author
There was a problem hiding this comment.
Suggested change
| website_url VARCHAR(255) | |
| website_url VARCHAR(255), |
| @@ -1,69 +1,86 @@ | |||
| CREATE EXTENSION IF NOT EXISTS "uuid-ossp"; | |||
| DROP TYPE IF EXISTS organization_status_type; | |||
Owner
Author
There was a problem hiding this comment.
Thêm cái này mới dùng được hàm uuid_generate_v4()
Suggested change
| DROP TYPE IF EXISTS organization_status_type; | |
| CREATE EXTENSION IF NOT EXISTS "uuid-ossp"; | |
| DROP TYPE IF EXISTS organization_status_type; |
|
|
||
| CREATE TABLE IF NOT EXISTS sso_roles ( | ||
| role_id UUID DEFAULT uuid_generate_v4() PRIMARY KEY, | ||
| role_name VARCHAR(255) NOT NULL |
Owner
Author
There was a problem hiding this comment.
Suggested change
| role_name VARCHAR(255) NOT NULL | |
| role_name VARCHAR(255) NOT NULL, |
| role_description VARCHAR(255), | ||
| organization_id INT NOT NULL, | ||
| status organization_status_type, | ||
| PRIMARY KEY (role_id) |
Owner
Author
There was a problem hiding this comment.
Suggested change
| PRIMARY KEY (role_id) | |
| PRIMARY KEY (role_id), |
|
|
||
| CREATE TABLE IF NOT EXISTS sso_user_profile ( | ||
| profile_id UUID DEFAULT uuid_generate_v4() PRIMARY KEY, | ||
| profile_id UUID DEFAULT uuid_generate_v4(), |
Owner
Author
There was a problem hiding this comment.
Suggested change
| profile_id UUID DEFAULT uuid_generate_v4(), | |
| profile_id UUID DEFAULT uuid_generate_v4() NOT NULL, |
| FOREIGN KEY (organization_id) REFERENCES sso_organization(organization_id), | ||
| date_created TIMESTAMP DEFAULT CURRENT_TIMESTAMP, | ||
| date_modified TIMESTAMP DEFAULT CURRENT_TIMESTAMP, | ||
| PRIMARY KEY(profile_id) |
Owner
Author
There was a problem hiding this comment.
Suggested change
| PRIMARY KEY(profile_id) | |
| PRIMARY KEY(profile_id), |
| FOREIGN KEY (user_id) REFERENCES sso_user(user_id) | ||
| ); | ||
|
|
||
| CREATE TABLE IF NOT EXISTS sso_roles ( |
Owner
Author
There was a problem hiding this comment.
Tên bảng để số ít thôi nhé
Suggested change
| CREATE TABLE IF NOT EXISTS sso_roles ( | |
| CREATE TABLE IF NOT EXISTS sso_role ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.