Lesson 2 - Dao Thi Quynh Anh #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndthang15
commented
Nov 1, 2023
| create type gender_type | ||
| as enum ('male', 'female'); | ||
| end if; | ||
| end $$; |
Owner
Author
There was a problem hiding this comment.
Rất tốt khi dùng transaction block trong Flyway. Sẽ tốt hơn nếu để cả file vào 1 transaction (Ví dụ: đưa do $$ begin lên đầu file, và end $$ xuống cuối cùng của file).
| end $$; | ||
|
|
||
| CREATE TABLE IF NOT EXISTS sso_organization ( | ||
| organization_id SERIAL NOT NULL, |
Owner
Author
There was a problem hiding this comment.
Suggested change
| organization_id SERIAL NOT NULL, | |
| organization_id SERIAL NOT NULL generated always as identity, |
| ); | ||
|
|
||
| CREATE TABLE IF NOT EXISTS sso_role ( | ||
| role_id uuid NOT NULL, |
Owner
Author
There was a problem hiding this comment.
Đặt thêm default để ID này có thể tự sinh nếu câu INSERT không gen sẵn uuid truyền vào.
Suggested change
| role_id uuid NOT NULL, | |
| role_id uuid NOT NULL DEFAULT uuid_generate_v4(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.