Lesson 2 - Nguyen Minh Hai #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndthang15
commented
Nov 1, 2023
Comment on lines
+8
to
+9
| DROP TABLE IF EXISTS sso_organization; | ||
| CREATE TABLE sso_organization ( |
Owner
Author
There was a problem hiding this comment.
Không nên xóa bảng vì có thể gây mất dữ liệu. Chỉ cần câu lệnh CREATE TABLE IF NOT EXISTS thì sẽ không bị lỗi khi bảng đã tồn tại.
Suggested change
| DROP TABLE IF EXISTS sso_organization; | |
| CREATE TABLE sso_organization ( | |
| CREATE TABLE IF NOT EXISTS sso_organization ( |
Comment on lines
+26
to
+27
| DROP TABLE IF EXISTS sso_role; | ||
| CREATE TABLE sso_role( |
Owner
Author
There was a problem hiding this comment.
Suggested change
| DROP TABLE IF EXISTS sso_role; | |
| CREATE TABLE sso_role( | |
| CREATE TABLE IF NOT EXISTS sso_role( |
|
|
||
| DROP TABLE IF EXISTS sso_role; | ||
| CREATE TABLE sso_role( | ||
| role_id uuid DEFAULT gen_random_uuid() PRIMARY KEY, |
Owner
Author
There was a problem hiding this comment.
Nếu dùng UUID muốn gen random uuid cần cài thêm extension CREATE EXTENSION IF NOT EXISTS "uuid-ossp";
Suggested change
| role_id uuid DEFAULT gen_random_uuid() PRIMARY KEY, | |
| role_id uuid DEFAULT uuid_generate_v4() PRIMARY KEY, |
Comment on lines
+35
to
+36
| DROP TABLE IF EXISTS sso_user; | ||
| CREATE TABLE sso_user( |
Owner
Author
There was a problem hiding this comment.
Suggested change
| DROP TABLE IF EXISTS sso_user; | |
| CREATE TABLE sso_user( | |
| CREATE TABLE IF NOT EXISTS sso_user( |
Comment on lines
+50
to
+51
| DROP TABLE IF EXISTS sso_user_profile; | ||
| CREATE TABLE sso_user_profile ( |
Owner
Author
There was a problem hiding this comment.
Suggested change
| DROP TABLE IF EXISTS sso_user_profile; | |
| CREATE TABLE sso_user_profile ( | |
| CREATE TABLE IF NOT EXISTS sso_user_profile ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.