Skip to content

Warn on HSE mis-parse #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Warn on HSE mis-parse #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/Input/Haddock.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ fakePackage name desc = (Just $ Target (hackagePackageURL name) Nothing Nothing

-- | Given a file name (for errors), feed in lines to the conduit and emit either errors or items
parseHoogle :: Monad m => (String -> m ()) -> URL -> LBStr -> ConduitM i (Maybe Target, [Item]) m ()
parseHoogle warning url body = sourceLStr body .| linesCR .| zipFromC 1 .| parserC warning .| hierarchyC url .| mapC (\x -> rnf x `seq` x)
parseHoogle warning url body = sourceLStr body .| linesCR .| zipFromC 1 .| parserC warning .| hierarchyC warning url .| mapC (\x -> rnf x `seq` x)

parserC :: Monad m => (String -> m ()) -> ConduitM (Int, BStr) (Target, Entry) m ()
parserC warning = f [] ""
Expand Down Expand Up @@ -71,22 +71,30 @@ reformat :: [BStr] -> String
reformat = unlines . map bstrUnpack


hierarchyC :: Monad m => URL -> ConduitM (Target, Entry) (Maybe Target, [Item]) m ()
hierarchyC packageUrl = void $ mapAccumC f (Nothing, Nothing)
hierarchyC :: Monad m => (String -> m ()) -> URL -> ConduitM (Target, Entry) (Maybe Target, [Item]) m ()
hierarchyC warning packageUrl = void $ mapAccumMC f (Nothing, Nothing)
where
f (pkg, mod) (t, EPackage x) = ((Just (strUnpack x, url), Nothing), (Just t{targetURL=url}, [IPackage x]))
f (pkg, mod) (t, EPackage x) = return ((Just (strUnpack x, url), Nothing), (Just t{targetURL=url}, [IPackage x]))
where url = targetURL t `orIfNull` packageUrl
f (pkg, mod) (t, EModule x) = ((pkg, Just (strUnpack x, url)), (Just t{targetPackage=pkg, targetURL=url}, [IModule x]))
f (pkg, mod) (t, EModule x) = return ((pkg, Just (strUnpack x, url)), (Just t{targetPackage=pkg, targetURL=url}, [IModule x]))
where url = targetURL t `orIfNull` (if isGhc then ghcModuleURL x else hackageModuleURL x)
f (pkg, mod) (t, EDecl i@InstDecl{}) = ((pkg, mod), (Nothing, hseToItem_ i))
f (pkg, mod) (t, EDecl x) = ((pkg, mod), (Just t{targetPackage=pkg, targetModule=mod, targetURL=url}, hseToItem_ x))
f (pkg, mod) (t, EDecl i@InstDecl{}) = do
item <- tryHseToItem i
return ((pkg, mod), (Nothing, item))
f (pkg, mod) (t, EDecl x) = do
item <- tryHseToItem x
return ((pkg, mod), (Just t{targetPackage=pkg, targetModule=mod, targetURL=url}, item))
where url = targetURL t `orIfNull` case x of
_ | [n] <- declNames x -> hackageDeclURL (isTypeSig x) n
| otherwise -> ""

isGhc = "~ghc" `isInfixOf` packageUrl || "/" `isSuffixOf` packageUrl

hseToItem_ x = hseToItem x `orIfNull` error ("hseToItem failed, " ++ pretty x)
tryHseToItem x = do
let item = hseToItem x
when (null item) $ warning ("hseToItem failed, " ++ pretty x)
return item

infix 1 `orIfNull`
orIfNull x y = if null x then y else x

Expand Down