Skip to content

Remove ez-conf-lib:exe variable #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gridbugs
Copy link

This package used to provide a variable exe containing the absolute path to the ez-conf-lib script inside the current opam switch. The problem with using an absolute path here is it means the switch is not portable. This causes problems for dune packag emanagement where all packages are first installed to a temporary sandbox and then moved to a final location afterwards.

Clients of ez-conf-lib are updated to refer to the script without using the exe variable in: ocaml/opam-repository#27759

This package used to provide a variable `exe` containing the absolute
path to the `ez-conf-lib` script inside the current opam switch. The
problem with using an absolute path here is it means the switch is not
portable. This causes problems for dune packag emanagement where all
packages are first installed to a temporary sandbox and then moved to a
final location afterwards.

Clients of ez-conf-lib are updated to refer to the script without using
the exe variable in: ocaml/opam-repository#27759

Signed-off-by: Stephen Sherratt <[email protected]>
@nberth
Copy link
Owner

nberth commented Apr 15, 2025

I'm now wondering, this PR is just about removing a variable that would be totally fine to use outside of dune package management. Removing the variable does not appear to be a requirement for ocaml/opam-repository#27759.
Considering this, I think I'd rather keep that feature in and just add a note in the README about that, as it's not an issue when just using opam instead of dune package management (that I actually don't know much about).

@nberth
Copy link
Owner

nberth commented Apr 15, 2025

@gridbugs I'd just go with #7 instead, unless keeping the package variable is still an issue (for cache management?).

@gridbugs
Copy link
Author

gridbugs commented Apr 17, 2025

Ok yeh happy to go with #7 for now. Interesting point about cache management. I think it will be fine, since I believe dune uses hashes of build rules as keys in its cache, and assumes the contents of files (generated or static) are a pure function of the build rules. This is of course patently untrue in some situations (such as this one) however I think this case is benign provided ocaml/opam-repository#27759 is merged.

@gridbugs gridbugs closed this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants