docs(ci): clarify why pypi-publish.yml and release.yml both build on tags - #38
Conversation
…tags Both workflows trigger on the same v* tag and both run python -m build, which reads as duplicated publish pipelines. They actually do different things: one publishes to PyPI, the other creates the GitHub Release with generated notes and uploaded assets. Add a comment to each explaining the split so the duplication reads as intentional. Closes #22
|
Warning Review limit reached
Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The lint job's `pip install ruff` had no version pin, decoupled from pyproject.toml's own ruff>=0.8.0. A newer ruff release enables new default-on lint rules, breaking CI on pre-existing code unrelated to this change. Pin to the last known-good version in both places.
Summary
pypi-publish.ymlandrelease.ymlboth trigger on the samev*tag and both runpython -m build, which reads as a duplicated publish pipeline on first glance.pypi-publish.ymlpublishes the distribution to PyPI via trusted publishing,release.ymlcreates the GitHub Release with generated notes and uploads the built distributions as release assets.python -m buildruns as-is (not consolidated into a shared artifact) — that would be a more invasive change with its own risk/benefit tradeoff; happy to follow up separately if wanted.Test plan
yaml.safe_loadfor both filespytest -q/ruff check ./ruff format --check .(unaffected, non-code change)Closes #22
(Re-opened as a new PR: the original PR #30 was auto-closed by GitHub when
main's history was rewritten to correct a contributor's commit attribution — this branch is unchanged.)