Skip to content

ci: run tests on Windows in addition to Ubuntu - #35

Merged
nazarli-shabnam merged 2 commits into
mainfrom
ci/add-windows-matrix
Jul 25, 2026
Merged

ci: run tests on Windows in addition to Ubuntu#35
nazarli-shabnam merged 2 commits into
mainfrom
ci/add-windows-matrix

Conversation

@nazarli-shabnam

Copy link
Copy Markdown
Owner

Summary

  • git.py/run.py have explicit Windows codepage handling and cli.py has PowerShell quoting logic (_ps_quote), but CI only ran on ubuntu-latest so none of that was actually exercised.
  • Added windows-latest to the test job's OS matrix alongside the existing Python version matrix (os x python-version), and updated the job name to include the OS.

Test plan

  • pytest -q / ruff check . / ruff format --check . locally on Windows (this repo's dev machine)
  • YAML validated with yaml.safe_load

Closes #19

(Re-opened as a new PR: the original PR #27 was auto-closed by GitHub when main's history was rewritten to correct a contributor's commit attribution — this branch is unchanged.)

git.py/run.py have Windows-specific UTF-8 codepage handling and
cli.py has PowerShell quoting logic, none of which was exercised by
CI (ubuntu-latest only). Add windows-latest to the test job's OS
matrix alongside the existing Python version matrix.

Closes #19
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nazarli-shabnam, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 8 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 10959e38-0fcb-4a11-ba29-22c753440b50

📥 Commits

Reviewing files that changed from the base of the PR and between 11a379a and b9ea769.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • pyproject.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/add-windows-matrix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The lint job's `pip install ruff` had no version pin, decoupled from
pyproject.toml's own ruff>=0.8.0. A newer ruff release enables new
default-on lint rules, breaking CI on pre-existing code unrelated to
this change. Pin to the last known-good version in both places.
@nazarli-shabnam nazarli-shabnam self-assigned this Jul 25, 2026
@nazarli-shabnam
nazarli-shabnam merged commit e12c92e into main Jul 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI only runs on Ubuntu despite Windows-specific code paths

1 participant