ci: run tests on Windows in addition to Ubuntu - #35
Conversation
git.py/run.py have Windows-specific UTF-8 codepage handling and cli.py has PowerShell quoting logic, none of which was exercised by CI (ubuntu-latest only). Add windows-latest to the test job's OS matrix alongside the existing Python version matrix. Closes #19
|
Warning Review limit reached
Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The lint job's `pip install ruff` had no version pin, decoupled from pyproject.toml's own ruff>=0.8.0. A newer ruff release enables new default-on lint rules, breaking CI on pre-existing code unrelated to this change. Pin to the last known-good version in both places.
Summary
git.py/run.pyhave explicit Windows codepage handling andcli.pyhas PowerShell quoting logic (_ps_quote), but CI only ran onubuntu-latestso none of that was actually exercised.windows-latestto thetestjob's OS matrix alongside the existing Python version matrix (osxpython-version), and updated the job name to include the OS.Test plan
pytest -q/ruff check ./ruff format --check .locally on Windows (this repo's dev machine)yaml.safe_loadCloses #19
(Re-opened as a new PR: the original PR #27 was auto-closed by GitHub when
main's history was rewritten to correct a contributor's commit attribution — this branch is unchanged.)