Skip to content

test(gemini): cover suggest_commands end-to-end and fallback retry - #34

Merged
nazarli-shabnam merged 2 commits into
mainfrom
test/gemini-suggest-commands-coverage
Jul 25, 2026
Merged

test(gemini): cover suggest_commands end-to-end and fallback retry#34
nazarli-shabnam merged 2 commits into
mainfrom
test/gemini-suggest-commands-coverage

Conversation

@nazarli-shabnam

Copy link
Copy Markdown
Owner

Summary

  • suggest_commands() in gemini.py (the actual Gemini call + response parsing + fallback-chain retry logic) had no test coverage — only its small helper functions were tested.
  • Added tests/test_gemini_suggest_commands.py with a lightweight fake genai.Client, covering: a successful parse, retry-on-429 falling through AI_MODEL_FALLBACKS (with fallback_notifier verified), a non-retryable error propagating without trying fallbacks, the generic-AI-message path falling back to the local heuristic message, missing-API-key, and empty-diff short-circuit.

Test plan

  • pytest -q
  • ruff check . / ruff format --check .

Closes #18

(Re-opened as a new PR: the original PR #26 was auto-closed by GitHub when main's history was rewritten to correct a contributor's commit attribution — this branch is unchanged.)

Existing tests only covered small helpers in gemini.py; the actual
Gemini call path (response parsing, retry across AI_MODEL_FALLBACKS
on 429/503, non-retryable errors propagating immediately, and the
generic-message local-fallback path) was untested. Add tests using a
fake genai.Client to cover each case.

Closes #18
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nazarli-shabnam, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e909f8e3-25d4-4fe6-903c-b935e0478be8

📥 Commits

Reviewing files that changed from the base of the PR and between 11a379a and 8568d18.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • pyproject.toml
  • tests/test_gemini_suggest_commands.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/gemini-suggest-commands-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The lint job's `pip install ruff` had no version pin, decoupled from
pyproject.toml's own ruff>=0.8.0. A newer ruff release enables new
default-on lint rules, breaking CI on pre-existing code unrelated to
this change. Pin to the last known-good version in both places.
@nazarli-shabnam nazarli-shabnam self-assigned this Jul 25, 2026
@nazarli-shabnam
nazarli-shabnam merged commit cd3f2c4 into main Jul 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No test coverage for suggest_commands() end-to-end and fallback-chain retry

1 participant