test(gemini): cover suggest_commands end-to-end and fallback retry - #34
Conversation
Existing tests only covered small helpers in gemini.py; the actual Gemini call path (response parsing, retry across AI_MODEL_FALLBACKS on 429/503, non-retryable errors propagating immediately, and the generic-message local-fallback path) was untested. Add tests using a fake genai.Client to cover each case. Closes #18
|
Warning Review limit reached
Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The lint job's `pip install ruff` had no version pin, decoupled from pyproject.toml's own ruff>=0.8.0. A newer ruff release enables new default-on lint rules, breaking CI on pre-existing code unrelated to this change. Pin to the last known-good version in both places.
Summary
suggest_commands()ingemini.py(the actual Gemini call + response parsing + fallback-chain retry logic) had no test coverage — only its small helper functions were tested.tests/test_gemini_suggest_commands.pywith a lightweight fakegenai.Client, covering: a successful parse, retry-on-429 falling throughAI_MODEL_FALLBACKS(withfallback_notifierverified), a non-retryable error propagating without trying fallbacks, the generic-AI-message path falling back to the local heuristic message, missing-API-key, and empty-diff short-circuit.Test plan
pytest -qruff check ./ruff format --check .Closes #18
(Re-opened as a new PR: the original PR #26 was auto-closed by GitHub when
main's history was rewritten to correct a contributor's commit attribution — this branch is unchanged.)