-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ung fordel #112
Ung fordel #112
Conversation
edd2c69
to
d8d0ed6
Compare
fordel/src/main/java/no/nav/ung/domenetjenester/arkiv/journal/TilJournalføringTjeneste.java
Show resolved
Hide resolved
...l/src/main/java/no/nav/ung/domenetjenester/arkiv/journalpostvurderer/Vurderingsgrunnlag.java
Outdated
Show resolved
Hide resolved
fordel/src/main/java/no/nav/ung/domenetjenester/personhendelser/PdlLeesahHendelseStream.java
Outdated
Show resolved
Hide resolved
fordel/src/main/java/no/nav/ung/domenetjenester/personhendelser/PdlLeesahHendelseStream.java
Outdated
Show resolved
Hide resolved
fordel/src/main/java/no/nav/ung/fordel/kafka/DefaultKafkaSettings.java
Outdated
Show resolved
Hide resolved
fordel/src/main/java/no/nav/ung/fordel/repo/FrisinnSøknadTaskPropsEntitet.java
Outdated
Show resolved
Hide resolved
fordel/src/main/java/no/nav/ung/fordel/repo/ProduksjonsstyringOppgaveEntitet.java
Outdated
Show resolved
Hide resolved
kodeverk/src/main/java/no/nav/ung/kodeverk/dokument/FordelBehandlingType.java
Show resolved
Hide resolved
migreringer/src/main/resources/db/postgres/defaultDS/1.0/V1.0_012__tabeller_for_fordel.sql
Outdated
Show resolved
Hide resolved
primary key, | ||
aktoer_id varchar(50), | ||
kanal varchar(100), | ||
tittel varchar(4000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trenger vi å sette en grense når den er på 4000 tegn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eller bruke text. Vet ikke hva som blir forskjellen .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kva er problemet med å setje ei grense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det er ikkje eit problem, tenkte berre at tallet er så stort at det vel i praksis ikkje er ei grense
migreringer/src/main/resources/db/postgres/defaultDS/1.0/V1.0_012__tabeller_for_fordel.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Digg!
Er det fortsatt noen som bruker denne resttjenesten?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eg var litt usikker, så eg beholder den enn så lenge. Det kan vere at vi må ta inn igjen nokon av desse metodene, i alle fall ha mulighet til å kalle dei fra swagger
web/src/main/java/no/nav/ung/sak/web/app/selftest/HealthCheckRestService.java
Outdated
Show resolved
Hide resolved
web/src/main/java/no/nav/ung/sak/web/app/selftest/HealthCheckRestService.java
Outdated
Show resolved
Hide resolved
( | ||
id bigint not null | ||
primary key, | ||
journalpostid varchar(50) not null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jeg ser at vi har begynt å bruke
character varying(100) istedenfor varchar. Vet ikke hvorfor 😅
Jeg foretrekker egentlig varchar,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det var vel baseline skriptet som blei generert feil. Eg tenkjer vi kan bruke varchar
MottattMelding nesteStegMm = doTask(mm); | ||
|
||
if (nesteStegMm != null) { | ||
tjenester.getMeldingTjeneste().oppdaterMottattMelding(nesteStegMm); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hvis man kunne kvitte seg meg mutering av MottattMelding så hadde det vært veldig nice. 😅 Ikke denne PR.
fordel/src/main/java/no/nav/ung/domenetjenester/personhendelser/SendInnUngHendelseTask.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Til evt. neste PR
Kunne denne og SendInnUngHendelseTask merges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ein grunn til å beholde taskene slik dei er i dag er for å kunne gjere kall til dokumenthåndtering for journalføring i slutten av ein transaksjon. Dette gjerast i mellom desse to taskene
No description provided.