Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ung fordel #112

Merged
merged 53 commits into from
Jan 17, 2025
Merged

Ung fordel #112

merged 53 commits into from
Jan 17, 2025

Conversation

espenjv
Copy link
Contributor

@espenjv espenjv commented Jan 10, 2025

No description provided.

@espenjv espenjv marked this pull request as ready for review January 13, 2025 08:07
@espenjv espenjv requested a review from a team as a code owner January 13, 2025 08:07
@espenjv espenjv force-pushed the ung-fordel branch 2 times, most recently from edd2c69 to d8d0ed6 Compare January 15, 2025 13:12
deploy/dev-gcp.yml Outdated Show resolved Hide resolved
deploy/prod-gcp.yml Outdated Show resolved Hide resolved
fordel/pom.xml Outdated Show resolved Hide resolved
primary key,
aktoer_id varchar(50),
kanal varchar(100),
tittel varchar(4000),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trenger vi å sette en grense når den er på 4000 tegn?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eller bruke text. Vet ikke hva som blir forskjellen .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kva er problemet med å setje ei grense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det er ikkje eit problem, tenkte berre at tallet er så stort at det vel i praksis ikkje er ei grense

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digg!
Er det fortsatt noen som bruker denne resttjenesten?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eg var litt usikker, så eg beholder den enn så lenge. Det kan vere at vi må ta inn igjen nokon av desse metodene, i alle fall ha mulighet til å kalle dei fra swagger

(
id bigint not null
primary key,
journalpostid varchar(50) not null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jeg ser at vi har begynt å bruke
character varying(100) istedenfor varchar. Vet ikke hvorfor 😅
Jeg foretrekker egentlig varchar,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det var vel baseline skriptet som blei generert feil. Eg tenkjer vi kan bruke varchar

MottattMelding nesteStegMm = doTask(mm);

if (nesteStegMm != null) {
tjenester.getMeldingTjeneste().oppdaterMottattMelding(nesteStegMm);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hvis man kunne kvitte seg meg mutering av MottattMelding så hadde det vært veldig nice. 😅 Ikke denne PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Til evt. neste PR
Kunne denne og SendInnUngHendelseTask merges?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ein grunn til å beholde taskene slik dei er i dag er for å kunne gjere kall til dokumenthåndtering for journalføring i slutten av ein transaksjon. Dette gjerast i mellom desse to taskene

@ramrock93 ramrock93 self-requested a review January 17, 2025 12:39
@espenjv espenjv merged commit 95d97f3 into master Jan 17, 2025
7 of 8 checks passed
@espenjv espenjv deleted the ung-fordel branch January 17, 2025 12:44
qtips added a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants