Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erstatter amplitude med Umami hvis det finnes en umami_id #340

Merged
merged 28 commits into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
04e2691
Erstatter amplitude med Umami hvis det finnes en umami_id
tepose Dec 17, 2024
cbef931
Umammi skjuler uuid
tepose Dec 19, 2024
09d5439
Logg til både Amplitude og Umami
tepose Dec 19, 2024
8fd5f75
Merge branch 'main' into umami
tepose Dec 19, 2024
ce35ac4
Bruker bare umami hvis vi er localhost eller demo
tepose Jan 6, 2025
c4e4506
Merge branch 'main' into umami
tepose Jan 14, 2025
362172c
Merge branch 'main' into umami
tepose Jan 14, 2025
06060c2
Logger når skjemasteg starter og fullfører
tepose Jan 14, 2025
9809630
Legger til mulighet for å skru av logging til Amplitude og Umami
Zandra7 Jan 15, 2025
dc298b2
Legger til SKAL_LOGGE variabel i .env.example
Zandra7 Jan 15, 2025
7b14ece
Legger til tracking av foretrukket språk
Zandra7 Jan 21, 2025
e73246e
Sjekker om Umami kan logges til
tepose Jan 21, 2025
11a4de1
Merge branch 'main' into umami
Zandra7 Jan 21, 2025
f481f6e
Legger til tracking på 'les mer' filtrene
Zandra7 Jan 21, 2025
e108a61
Fikser 'skal_logge' verdi
Zandra7 Jan 21, 2025
7791f9f
Gjør om SKAL_LOGGE til boolean
Zandra7 Jan 21, 2025
8283962
Gjør SKAL_LOGGE om til string igjen
Zandra7 Jan 21, 2025
64f52fa
Endrer SKAL_LOGGE verdien til å være en string
Zandra7 Jan 22, 2025
bb9121f
Legger til UMAMI_ID i nais.demo.yaml
Zandra7 Jan 22, 2025
46d8391
Legger til debounce funksjon for å optimalisere tracking av les mer f…
Zandra7 Jan 22, 2025
3948b63
Gjør klar til logging
tepose Jan 31, 2025
36add20
Oppdater dekoratøren
tepose Jan 31, 2025
01fe03d
Bort med SKAL_LOGGE, inn med consent fra dekoratøren
tepose Feb 3, 2025
dca709d
Logger tid brukt i aktivitetsmodalen
tepose Feb 3, 2025
ae1179e
Logg modal lukket med antall aktiviteter
tepose Feb 4, 2025
725b0ff
Oppdater nav-dekoratoren-moduler
tepose Feb 4, 2025
947f061
Legg til umami i prod
tepose Feb 4, 2025
6f79de7
hash skjemaId
tepose Feb 4, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ NAIS_CLUSTER_NAME="dev-gcp"
USE_MSW="true"
SANITY_DATASETT="development"
FARO_URL="http://localhost:12347/collect"
GITHUB_SHA="local"
GITHUB_SHA="local"
UMAMI_ID="24bd3b5d-f1e6-446c-a551-0bf556592157"
4 changes: 3 additions & 1 deletion .nais/nais.demo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,11 @@ spec:
- name: FARO_URL
value: {{faro_url}}
- name: RUNTIME_ENVIRONMENT
value: {{RUNTIME_ENVIRONMENT}}
value: {{runtime_environment}}
- name: SANITY_DATASETT
value: {{sanity_datasett}}
- name: UMAMI_ID
value: {{umami_id}}
accessPolicy:
outbound:
external:
Expand Down
2 changes: 2 additions & 0 deletions .nais/nais.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ spec:
value: {{faro_url}}
- name: SANITY_DATASETT
value: {{sanity_datasett}}
- name: UMAMI_ID
value: {{umami_id}}
accessPolicy:
outbound:
external:
Expand Down
3 changes: 2 additions & 1 deletion .nais/vars-demo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ dekorator:
url: https://dekoratoren.dev.nav.no/
env: dev
faro_url: "https://telemetry.ekstern.dev.nav.no/collect"
RUNTIME_ENVIRONMENT: "demo"
runtime_environment: "demo"
sanity_datasett: "production"
umami_id: "24bd3b5d-f1e6-446c-a551-0bf556592157"
1 change: 1 addition & 0 deletions .nais/vars-dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ dekorator:
env: dev
faro_url: "https://telemetry.ekstern.dev.nav.no/collect"
sanity_datasett: "development"
umami_id: "ccee3ffe-f3c3-4ef6-8e01-742756847782"
replicas:
min: 2
max: 2
Expand Down
3 changes: 2 additions & 1 deletion .nais/vars-prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ dekorator:
env: prod
faro_url: "https://telemetry.nav.no/collect"
sanity_datasett: "production"
umami_id: "feb08edd-87bf-4617-a22f-363ce00d48f6"
replicas:
min: 2
max: 2
max: 2
4 changes: 2 additions & 2 deletions app/components/Kvittering.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { AktivitetOppsummering } from "~/components/aktivitet-oppsummering/Aktiv
import { Kalender } from "~/components/kalender/Kalender";
import navigasjonStyles from "~/components/navigasjon-container/NavigasjonContainer.module.css";
import { RemixLink } from "~/components/RemixLink";
import { useAmplitude } from "~/hooks/useAmplitude";
import { useAnalytics } from "~/hooks/useAnalytics";
import { useLocale } from "~/hooks/useLocale";
import { useSanity } from "~/hooks/useSanity";
import { useUXSignals } from "~/hooks/useUXSignals";
Expand All @@ -27,7 +27,7 @@ interface Ikvittering {
export function Kvittering({ tittel, periode, harNestePeriode }: Ikvittering) {
const { getAppText, getLink } = useSanity();
const { locale } = useLocale();
const { trackNavigere } = useAmplitude();
const { trackNavigere } = useAnalytics();

if (typeof window !== "undefined" && window["hj"]) {
window.hj("trigger", "nyttmeldekortDP");
Expand Down
27 changes: 25 additions & 2 deletions app/components/LesMer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Checkbox, CheckboxGroup, ReadMore } from "@navikt/ds-react";
import { PortableText } from "@portabletext/react";
import { useState } from "react";

import { useAmplitude } from "~/hooks/useAmplitude";
import { useAnalytics } from "~/hooks/useAnalytics";
import { useSanity } from "~/hooks/useSanity";
import { AktivitetType, aktivitetTypeMap } from "~/utils/aktivitettype.utils";

Expand Down Expand Up @@ -33,9 +33,10 @@ export const lesMerInnhold = [

export function LesMer({ periodeId }: IProps) {
const { getRichText, getAppText } = useSanity();
const { trackAccordionApnet, trackAccordionLukket } = useAmplitude();
const { trackAccordionApnet, trackAccordionLukket, trackLesMerFilter } = useAnalytics();

const [selectedValues, setSelectedValues] = useState<string[]>([]);
const [timer, setTimer] = useState<ReturnType<typeof setTimeout> | undefined>(undefined);

const tekstId = "rapportering-les-mer-hva-skal-rapporteres-tittel";
const header = getAppText(tekstId);
Expand All @@ -48,8 +49,30 @@ export function LesMer({ periodeId }: IProps) {
}
}

function debounce(fn: () => void, timeout = 3000) {
if (timer) {
clearTimeout(timer);
setTimer(undefined);
}

setTimer(
setTimeout(() => {
fn();
}, timeout),
);
}

function handleCheckboxChange(values: string[]) {
setSelectedValues(values);

debounce(() => {
trackLesMerFilter({
arbeid: values.includes(AktivitetType.Arbeid),
syk: values.includes(AktivitetType.Syk),
fravaer: values.includes(AktivitetType.Fravaer),
utdanning: values.includes(AktivitetType.Utdanning),
});
});
}

const filtrertInnhold = lesMerInnhold.filter(
Expand Down
4 changes: 2 additions & 2 deletions app/components/aktivitet-checkbox/AktivitetCheckboxes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { PortableText } from "@portabletext/react";
import classNames from "classnames";
import { useField } from "remix-validated-form";

import { useAmplitude } from "~/hooks/useAmplitude";
import { useAnalytics } from "~/hooks/useAnalytics";
import { type GetAppText, useSanity } from "~/hooks/useSanity";
import { AktivitetType, aktivitetTypeMap, IAktivitet } from "~/utils/aktivitettype.utils";
import { periodeSomTimer } from "~/utils/periode.utils";
Expand Down Expand Up @@ -66,7 +66,7 @@ export function AktivitetCheckboxes({
}: IProps) {
const { error } = useField(name);
const { getAppText, getRichText } = useSanity();
const { trackAccordionApnet, trackAccordionLukket } = useAmplitude();
const { trackAccordionApnet, trackAccordionLukket } = useAnalytics();

const tekstId = "rapportering-aktivitet-jobb-prosentstilling-tittel";
const header = getAppText(tekstId);
Expand Down
59 changes: 53 additions & 6 deletions app/components/aktivitet-modal/AktivitetModal.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import { Alert, Button, Heading, Modal } from "@navikt/ds-react";
import { useActionData, useFetcher, useNavigation } from "@remix-run/react";
import { useEffect, useRef } from "react";
import { useEffect, useRef, useState } from "react";
import { ValidatedForm } from "remix-validated-form";
import { uuidv7 } from "uuidv7";

import { useAnalytics } from "~/hooks/useAnalytics";
import { useLocale } from "~/hooks/useLocale";
import { useSanity } from "~/hooks/useSanity";
import type { IRapporteringsperiode } from "~/models/rapporteringsperiode.server";
Expand Down Expand Up @@ -37,15 +39,42 @@ export function AktivitetModal({

const { getAppText } = useSanity();
const actionData = useActionData<typeof rapporteringAction>();
const [sesjonId, setSesjonId] = useState<string>("");
const modalId = "aktivitet-modal";

const dag = periode.dager.find((dag) => dag.dato === valgtDato);

const fetcher = useFetcher();
const navigation = useNavigation();
const isSubmitting = useIsSubmitting(navigation);
const modalRef = useRef<HTMLDivElement>(null);
const { trackModalApnet, trackModalLukket } = useAnalytics();
const [harLoggetLukket, setHarLoggetLukket] = useState<boolean>(false);

const slettHandler = () => {
function loggModalLukket(knapp: string, antallAktiviteter: number) {
if (harLoggetLukket) return;

/**
* onClose kalles ved alle handlinger som lukker modalen, men er også den
* eneste metoden vi har for å lytte på avbryt-knappen. onClose er den siste
* metoden som blir kalt, så her sørger vi for at bare én logg blir sendt per
* 100ms
*/
setHarLoggetLukket(true);
setTimeout(() => {
setHarLoggetLukket(false);
}, 100);

trackModalLukket({
skjemaId: periode.id,
modalId,
sesjonId,
knapp,
antallAktiviteter,
});
}

function slettHandler() {
fetcher.submit(
{
rapporteringsperiodeId: periode.id,
Expand All @@ -54,12 +83,25 @@ export function AktivitetModal({
{ method: "post", action: "/api/slett" },
);

loggModalLukket("slett", 0);
lukkModal();
};
}

function onClose() {
loggModalLukket("lukk", 0);
lukkModal();
}

function onSubmit(data: { type: string[]; timer?: number }) {
loggModalLukket("lagre", data.type?.length ?? 0);
}

useEffect(() => {
if (modalAapen) {
modalRef?.current?.scrollTo({ top: 0 });
const id = uuidv7();
setSesjonId(id);
trackModalApnet({ skjemaId: periode.id, modalId, sesjonId: id });
}
}, [modalAapen]);

Expand All @@ -68,7 +110,7 @@ export function AktivitetModal({
className={styles.modal}
aria-labelledby="aktivitet-modal-heading"
open={modalAapen}
onClose={lukkModal}
onClose={onClose}
>
<Modal.Header>
<Heading
Expand All @@ -83,7 +125,12 @@ export function AktivitetModal({
</Modal.Header>
<Modal.Body ref={modalRef}>
{dag && (
<ValidatedForm method="post" key="lagre-ny-aktivitet" validator={validator()}>
<ValidatedForm
method="post"
key="lagre-ny-aktivitet"
validator={validator()}
onSubmit={onSubmit}
>
<input type="hidden" name="dato" defaultValue={valgtDato} />
<input type="hidden" name="dag" defaultValue={JSON.stringify(dag)} />

Expand All @@ -108,7 +155,7 @@ export function AktivitetModal({
)}

<div className={styles.knappKontainer}>
<Button variant="secondary" type="button" name="submit" onClick={slettHandler}>
<Button variant="secondary" type="button" onClick={slettHandler}>
{getAppText("rapportering-slett")}
</Button>
<Button type="submit" name="submit" value="lagre" disabled={isSubmitting}>
Expand Down
38 changes: 38 additions & 0 deletions app/components/analytics/Umami.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import { awaitDecoratorData, getCurrentConsent } from "@navikt/nav-dekoratoren-moduler";
import { useEffect, useState } from "react";

import { getEnv } from "~/utils/env.utils";

interface Consent {
analytics: boolean;
surveys: boolean;
}

async function getConsent(callback: (consent: Consent) => void) {
await awaitDecoratorData();
const { consent } = getCurrentConsent();
callback(consent);
}

export function Umami(): JSX.Element {
const umamiId = getEnv("UMAMI_ID");
const [userConsent, setUserConsent] = useState<Consent>({ analytics: false, surveys: false });

useEffect(() => {
getConsent(setUserConsent);
}, []);

return (
<>
{umamiId && (
<script
defer
src="https://cdn.nav.no/team-researchops/sporing/sporing-uten-uuid.js"
data-host-url="https://umami.nav.no"
data-website-id={umamiId}
data-auto-track={userConsent.analytics}
></script>
)}
</>
);
}
4 changes: 2 additions & 2 deletions app/components/error-boundary/GeneralErrorBoundary.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ErrorResponse, isRouteErrorResponse } from "@remix-run/react";
import { useEffect } from "react";

import navigasjonStyles from "~/components/navigasjon-container/NavigasjonContainer.module.css";
import { useAmplitude } from "~/hooks/useAmplitude";
import { useAnalytics } from "~/hooks/useAnalytics";
import { foundAppText, foundRichText, useSanity } from "~/hooks/useSanity";
import { setBreadcrumbs } from "~/utils/dekoratoren.utils";

Expand Down Expand Up @@ -76,7 +76,7 @@ export function useGetErrorText(error: unknown | IError): {
export function GeneralErrorBoundary({ error }: IProps) {
const { getAppText, getLink } = useSanity();
const { titleId, descriptionId, title, description } = useGetErrorText(error);
const { trackFeilmelding } = useAmplitude();
const { trackFeilmelding } = useAnalytics();

useEffect(() => {
setBreadcrumbs([], getAppText);
Expand Down
4 changes: 2 additions & 2 deletions app/components/kalender/Endringslenke.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useAmplitude } from "~/hooks/useAmplitude";
import { useAnalytics } from "~/hooks/useAnalytics";
import { useSanity } from "~/hooks/useSanity";

import { RemixLink } from "../RemixLink";
Expand All @@ -11,7 +11,7 @@ interface IProps {
export function EndringsLenke(props: IProps) {
const { getAppText } = useSanity();

const { trackSkjemaStartet, trackNavigere } = useAmplitude();
const { trackSkjemaStartet, trackNavigere } = useAnalytics();

const sti = "endre";
const linkId = "rapportering-redigeringslenke-endre";
Expand Down
5 changes: 1 addition & 4 deletions app/components/kalender/Uke.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import classNames from "classnames";
import { format } from "date-fns";

import { useAmplitude } from "~/hooks/useAmplitude";
import { useSanity } from "~/hooks/useSanity";
import type { IRapporteringsperiodeDag } from "~/models/rapporteringsperiode.server";
import { AktivitetType } from "~/utils/aktivitettype.utils";
Expand All @@ -19,9 +18,8 @@ interface IProps {
}

export function Uke(props: IProps) {
const { rapporteringUke, readonly, aapneModal, locale = DecoratorLocale.NB, periodeId } = props;
const { rapporteringUke, readonly, aapneModal, locale = DecoratorLocale.NB } = props;
const { getAppText } = useSanity();
const { trackModalApnet } = useAmplitude();

function erAktivStil(dag: IRapporteringsperiodeDag, typer: AktivitetType[]): boolean {
const dagenHarAktivitet = dag.aktiviteter.length > 0;
Expand Down Expand Up @@ -78,7 +76,6 @@ export function Uke(props: IProps) {
className={classNames(styles.dato, dagKnappStyle)}
aria-label={hentSkjermleserDatoTekst(dag, getAppText, locale)}
onClick={() => {
trackModalApnet(periodeId);
aapneModal(dag.dato);
}}
>
Expand Down
Loading
Loading