remove frame policy benchmark. (flutter#163245)

This benchmark is a benchmark of the integration test binding which IMO is not that important given that we continue to rely on flutter_driver for actual performance metrics.
navaronbracke · Feb 13, 2025 · 89311b7 · 89311b7
1 parent ce659cd
commit 89311b7
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 182 deletions.
diff --git a/.ci.yaml b/.ci.yaml
@@ -2739,15 +2739,6 @@ targets:
         ["devicelab", "android", "linux", "mokey"]
       task_name: flutter_view__start_up
 
-  - name: Linux_pixel_7pro frame_policy_delay_test_android
-    recipe: devicelab/devicelab_drone
-    presubmit: false
-    timeout: 60
-    properties:
-      tags: >
-        ["devicelab", "android", "linux", "pixel", "7pro"]
-      task_name: frame_policy_delay_test_android
-
   # linux mokey benchmark
   - name: Linux_mokey fullscreen_textfield_perf
     recipe: devicelab/devicelab_drone

diff --git a/TESTOWNERS b/TESTOWNERS
@@ -56,7 +56,6 @@
 /dev/devicelab/bin/tasks/flutter_gallery_v2_chrome_run_test.dart @yjbanov @flutter/web
 /dev/devicelab/bin/tasks/flutter_gallery_v2_web_compile_test.dart @yjbanov @flutter/web
 /dev/devicelab/bin/tasks/flutter_test_performance.dart @jtmcdole @flutter/engine
-/dev/devicelab/bin/tasks/frame_policy_delay_test_android.dart @jtmcdole @flutter/engine
 /dev/devicelab/bin/tasks/fullscreen_textfield_perf.dart @jtmcdole @flutter/engine
 /dev/devicelab/bin/tasks/fullscreen_textfield_perf__e2e_summary.dart @jtmcdole @flutter/engine
 /dev/devicelab/bin/tasks/gradient_consistent_perf__e2e_summary.dart @flar @flutter/engine

diff --git a/dev/benchmarks/macrobenchmarks/test/frame_policy.dart b/dev/benchmarks/macrobenchmarks/test/frame_policy.dart
diff --git a/dev/benchmarks/macrobenchmarks/test_driver/frame_policy_test.dart b/dev/benchmarks/macrobenchmarks/test_driver/frame_policy_test.dart
diff --git a/dev/devicelab/bin/tasks/frame_policy_delay_test_android.dart b/dev/devicelab/bin/tasks/frame_policy_delay_test_android.dart
diff --git a/dev/devicelab/lib/tasks/perf_tests.dart b/dev/devicelab/lib/tasks/perf_tests.dart
@@ -534,51 +534,6 @@ TaskFunction createsScrollSmoothnessPerfTest() {
   };
 }
 
-TaskFunction createFramePolicyIntegrationTest() {
-  final String testDirectory = '${flutterDirectory.path}/dev/benchmarks/macrobenchmarks';
-  const String testTarget = 'test/frame_policy.dart';
-  return () {
-    return inDirectory<TaskResult>(testDirectory, () async {
-      final Device device = await devices.workingDevice;
-      await device.unlock();
-      final String deviceId = device.deviceId;
-      await flutter('packages', options: <String>['get']);
-
-      await flutter(
-        'drive',
-        options: <String>[
-          '--no-android-gradle-daemon',
-          '-v',
-          '--verbose-system-logs',
-          '--profile',
-          '-t',
-          testTarget,
-          '-d',
-          deviceId,
-        ],
-      );
-      final Map<String, dynamic> data =
-          json.decode(
-                file(
-                  '${testOutputDirectory(testDirectory)}/frame_policy_event_delay.json',
-                ).readAsStringSync(),
-              )
-              as Map<String, dynamic>;
-      final Map<String, dynamic> fullLiveData = data['fullyLive'] as Map<String, dynamic>;
-      final Map<String, dynamic> benchmarkLiveData = data['benchmarkLive'] as Map<String, dynamic>;
-      final Map<String, dynamic> dataFormatted = <String, dynamic>{
-        'average_delay_fullyLive_millis': fullLiveData['average_delay_millis'],
-        'average_delay_benchmarkLive_millis': benchmarkLiveData['average_delay_millis'],
-        '90th_percentile_delay_fullyLive_millis': fullLiveData['90th_percentile_delay_millis'],
-        '90th_percentile_delay_benchmarkLive_millis':
-            benchmarkLiveData['90th_percentile_delay_millis'],
-      };
-
-      return TaskResult.success(dataFormatted, benchmarkScoreKeys: dataFormatted.keys.toList());
-    });
-  };
-}
-
 TaskFunction createOpacityPeepholeOneRectPerfE2ETest() {
   return PerfTest.e2e(
     '${flutterDirectory.path}/dev/benchmarks/macrobenchmarks',