-
Notifications
You must be signed in to change notification settings - Fork 0
feat: decision log guidelines and start #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add Vercel ai-chatbot (navapbc fork) as git submodule - Configured with Neon DB, Google Cloud Storage, and OpenAI - Enables chat functionality alongside main application
|
||
- Custom-built UI with Vercel AI SDK (PR #4) | ||
- Vercel AI SDK chatbot template (PR #13) | ||
- Third-party chat widget integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 3P integrations, I would recommend further looking into and surfacing these as options we reviewed, considered, or ruled-out:
- https://shadcn-chatbot-kit.vercel.app/
- https://www.langui.dev/
- any others you may have come across
I think we could then briefly expand on the "why" behind each good and bad in the Pros+Cons section for 3P integrations below.
- Good, because includes model selection dropdowns for testing | ||
- Good, because lighter weight and focused on chat functionality | ||
- Bad, because limited to chat interface only (no user management) | ||
- Bad, because requires integration with existing Mastra backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would also be a consequence of Option 1, right?
Bad, because requires integration with existing Mastra backend
As you built out the initial phase for each solution where did the integration requirements differ?
- Bad, because poor user experience | ||
- Bad, because limited functionality | ||
|
||
### Full-stack framework like Next.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this an option you considered? Is the difference between this option and Option 1 that it does not use AI SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, my edits didn't save one sec
This is a good start! I liked how Christine and Jillian asked questions around some of the strategic differences. Would like if we could tailor the pros and cons more towards these.
|
feat: add browser WebSocket streaming service with CDP integration
- Update axios to >=1.12.0 (fixes DoS vulnerability) - Update hono to >=4.9.7 (fixes body limit middleware bypass) - Update various Mastra packages to latest versions - Resolve all known security vulnerabilities
fix: add debugging to mastra client
fix: update @mastra/memory to resolve thread validation error
Checklist
[INTENT]:[MESSAGE]
Ticket
Resolves #{TICKET NUMBER or URL or description} or Adds {new capability or feature}
Changes
This pull request adds a new architectural decision record to the documentation, outlining the evaluation of frontend UI framework options for implementing a chat interface for the Mastra bot. The document compares a custom-built UI approach with a template-based solution, highlighting the pros and cons of each, and provides context, decision drivers, and links to relevant technical stories.
Documentation: Decision Record for Frontend UI Framework
docs/decisions/ui-framework/000-custom-built-ui-vs-template-chat.md
to document the evaluation of custom-built UI versus template-based approaches for the Mastra bot chat interface, including decision drivers, considered options, pros and cons, and links to related PRs and resources.Context for reviewers
Decision log for tracking progress of application