Skip to content

accept tf_timeout < 0 to ignore timeout #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knorth55
Copy link
Contributor

this PR change to accept tf_timeout param -1 to ignore transformation timeout check.
this is useful when we use tf_static_transformer for debugging.

@corot
Copy link
Collaborator

corot commented Nov 24, 2023

Why not just passing a very big value?
And can u actually have a negative ros::Duration?

I would instead reconsider your use case; I'm not at all convince about the need of this change

@knorth55
Copy link
Contributor Author

knorth55 commented Nov 24, 2023

tf_static_publisher uses the first timestamp when node starts.
we run robots for weeks, so the duration will be super large.
so i use -1 as tf.lookUTransform

@knorth55
Copy link
Contributor Author

we dont use map and amcl, so we directly connect odom and map by tf_static_publisher.

@corot
Copy link
Collaborator

corot commented Sep 3, 2024

tf_static_publisher uses the first timestamp when node starts. we run robots for weeks, so the duration will be super large. so i use -1 as tf.lookUTransform

Yes, static tfs only need to be published once, but tf library considers them as always available, at any timestamp.
So that should not require this PR. You may have some other hidden problem in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants