Change to use supercover #322
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corot
approved these changes
Oct 22, 2023
renan028
force-pushed
the
rs/supercover
branch
from
cad2fa1 to
73599ed
Compare
renan028
force-pushed
the
rs/supercover
branch
from
5e45e6f to
8812e78
Compare
RainerKuemmerle
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed here: #317 (comment)
Bresenham line drawing misses grid squares that the ray passes through. The
supercoveralgorithm gets all the squares and it is the preferred algorithm to use when we search for possible collisions .Great description in Realtime Collision Detection "7.4.2 Uniform Grid Intersection Test".
In this PR, we are replacing
getLineCells(Bresenham) bysupercover, which is a more conservative approach.Note that we needed to change some tests because the resolution of the map is 1.0 and the robot size is 1.0 x 1.0, thus diagonals should cover all cells around with new
supercover.