This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
Pass over Chapter 1: Vectors #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shiffman - Just fyi, I will address the comments above before merging. Thanks! |
joeyklee
reviewed
Jul 25, 2019
shiffman
commented
Jul 25, 2019
…-code/noc-book-2 into chapter1-vector-shiffman-edits
|
Thank you for the comments @joeyklee! I made some changes based on them and replied in-line. Feel free to merge whenever! |
|
@shiffman - super! Thanks. Merging now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my pass over chapter 1 vectors. Some new issues were raised during this pass: nature-of-code/noc-book-2#61 nature-of-code/noc-book-2#60 nature-of-code/noc-book-2#144 nature-of-code/noc-book-2#58. I'll note a second pass in nature-of-code/noc-book-2#53.
@joeyklee I'll leave this unmerged for now in case it's helpful for you to review my work as a guide for future updates you make.