(#1268) Add mappings action to auth command #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploubser
force-pushed
the
issue_1268
branch
4 times, most recently
from
5a4d885 to
cd6abfe
Compare
ripienaar
requested changes
Mar 14, 2025
cli/auth_account_command.go
Outdated
| mappingsaAdd.Arg("target", "The target subject of the mapping").StringVar(&c.mapTarget) | ||
| mappingsaAdd.Arg("weight", "The weight (%) of the mappingmapping").Default("100").UintVar(&c.mapWeight) | ||
| mappingsaAdd.Flag("operator", "Operator to act on").StringVar(&c.operatorName) | ||
| mappingsaAdd.Flag("config", "JWT file to read configuration from").ExistingFileVar(&c.inputFile) |
There was a problem hiding this comment.
hmm, not sure we can really say read from a JWT, the idea with loading is that users can easily write a mapping in a file and load just that mapping, so we can kind of need to just load the jwt.Mapping from a file in json/yaml format
So I dont think for that use case users really would have JWTs around, its a convenient way to avoid all the flags and stuff
cli/auth_account_command.go
Outdated
| mappingsls.Flag("operator", "Operator to act on").StringVar(&c.operatorName) | ||
|
|
||
| mappingsrm := mappings.Command("rm", "Remove a mapping").Action(c.mappingRmAction) | ||
| mappingsrm.Arg("account", "Account to create the mappings on").StringVar(&c.accountName) |
There was a problem hiding this comment.
...remove the mappings from
ploubser
force-pushed
the
issue_1268
branch
2 times, most recently
from
74a01e0 to
9faa8af
Compare
|
Yeah woops, completely spoke past each other there. Updated to read the config from json/yaml |
mappings has `add`, `rm`, `list` and `info` commands. Add can take a --config flag pointing at a valid jwt, which it will then parse and extract the mappings from it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mappings has
add,rm,listandinfocommands.Add can take a --config flag pointing at a valid jwt, which it will then parse and extract the mappings from it.