Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async-nats: check push consumers in sample_freq de/serialisation test #1356

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

bengsparks
Copy link
Contributor

Followup from #1354

Previously merged test accidentally tested pull consumer configs twice, neglecting to test push consumer configs as well.

@bengsparks bengsparks changed the title async-nats: check push consumers in sample-freq de/serialisation test async-nats: check push consumers in sample_freq de/serialisation test Dec 30, 2024
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit 95e5f2e into nats-io:main Jan 2, 2025
12 checks passed
@bengsparks bengsparks deleted the testfix/sample-freq branch January 2, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants