Reject TTL messages when not enabled on stream #6370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
requested changes
Jan 14, 2025
server/jetstream_cluster.go
Outdated
| if ttl, _ := getMessageTTL(hdr); ttl != 0 && !allowTTL { | ||
| if canRespond { | ||
| var resp = &JSPubAckResponse{PubAck: &PubAck{Stream: name}} | ||
| resp.PubAck = &PubAck{Stream: name} |
There was a problem hiding this comment.
You set this above already. I think you can remove this line.
Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/ttldisabled
branch
from
74e187c to
e372c29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored out the rejection behaviour from #6298 so that it can be reviewed/merged separately from the sourcing/mirroring.
Signed-off-by: Neil Twigg [email protected]