Add support for "never expires" TTL #6319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
commented
Jan 6, 2025
neilalexander
force-pushed
the
neil/ttlnever
branch
2 times, most recently
from
e3b4f91 to
44c663c
Compare
A message with a `Nats-TTL` of a negative number will never expire, even if the `MaxAge` policy is set. Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/ttlnever
branch
from
44c663c to
0d5ad69
Compare
neilalexander
force-pushed
the
neil/ttlnever
branch
2 times, most recently
from
88f7988 to
e23f805
Compare
Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/ttlnever
branch
from
e23f805 to
e1e8b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A message with
Nats-TTL: neverwill never expire, even if theMaxAgepolicy is set.Signed-off-by: Neil Twigg [email protected]