Add more RAFT tests #4626
Open
Add more RAFT tests #4626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprimi
force-pushed
the
marco/raft-chain-test
branch
from
76267e5 to
6789d2d
Compare
mprimi
force-pushed
the
marco/raft-chain-test
branch
from
6789d2d to
e92592e
Compare
mprimi
force-pushed
the
marco/raft-chain-test
branch
from
e2744a4 to
7950364
Compare
mprimi
force-pushed
the
marco/raft-chain-test
branch
3 times, most recently
from
a73cbc3 to
7eb306e
Compare
Chain of Blocks is a simple state machine on top of Raft/NRG. Values delivered through Raft are hashed allowing for easy verification of replicas divergence. - Add one happy-path test - Add one test for recovery/catchup - Add a 'Long' randomized test
mprimi
force-pushed
the
marco/raft-chain-test
branch
from
7eb306e to
fc3553a
Compare
MauriceVanVeen
requested changes
Jan 3, 2025
Comment on lines
+154
to
+159
| sm.Lock() | ||
| defer sm.Unlock() | ||
| sm.n.Stop() | ||
| sm.wg.Wait() | ||
|
|
||
| // Clear state, on restart it will be recovered from snapshot or peers |
There was a problem hiding this comment.
When running locally it seems the test can lock up and not do anything/exceed the test duration.
Should be fixed by not holding the lock while waiting for Stop/Wait to complete The same logic is used in stateAdder.stop().
Suggested change
| sm.Lock() | |
| defer sm.Unlock() | |
| sm.n.Stop() | |
| sm.wg.Wait() | |
| // Clear state, on restart it will be recovered from snapshot or peers | |
| n, wg := sm.node(), sm.waitGroup() | |
| n.Stop() | |
| n.WaitForStop() | |
| wg.Wait() | |
| // Clear state, on restart it will be recovered from snapshot or peers | |
| sm.Lock() | |
| defer sm.Unlock() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'Chain of Blocks' tests for Raft/NRG
Chain of Blocks is a simple state machine on top of Raft/NRG.
Values delivered through Raft are hashed allowing for easy verification of replicas divergence.
Signed-off-by: [email protected]