Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Prompt Updates in getEMLfunctions.R #122

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Error Prompt Updates in getEMLfunctions.R #122

merged 2 commits into from
Feb 8, 2024

Conversation

James-R-Brown
Copy link
Contributor

Hey there,

Can you tell that I've been running into errors a lot as I continue learning how to use EMLeditor properly?

I patched up some typos present in a couple of error prompts throughout this file.

The other change might be a bit more subjective: I standardized the references to other functions to always end with a () to better indicate their status as functions within EMLeditor.

The only inconsistency remaining is where crayon::green$bold is used for the font of referred functions in some error prompts, but that seemed like a more deliberate decision to modify the font for those particular scenarios, so I decided against extending that change to the rest of the prompts.

Copy link
Member

@RobLBaker RobLBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - keep them coming. I think the crayon vs no crayon was partly a historial artifact of my learning how to use that function and/or thinking I should move it all over to cli & glue.

@RobLBaker RobLBaker merged commit 1484057 into nationalparkservice:main Feb 8, 2024
1 check failed
@James-R-Brown James-R-Brown deleted the jb-develop branch May 13, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants